Battery Storage Implementation (Second Attempt) #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
status: I still want to review this myself, but this may be a lot closer to a complete implementation than my last attempt untested yet, I intend to test this on my own 2 x Fronius inverter setup, I just want to script up making the required inverter technician setting changes (changing from export limitation to modbus control, disabling the native Fronius primary/secondary inverter integrations, etc - plus a rollback script to reverse it) so I can test it at various times of day/days when I have time, with a quick on/off execution. its a bit fiddly to test right now and have to roll it back between other unrelated (life/work) tasks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An AI generated attempt at fixing #68
Initially targets SunSpec only, but may be possible to extend to other inverters in future
I suspect this won't be 100% there, but maybe it provides a good foundation to solving this problem? :)
Quality looks a bit better than the first attempt, untested at the moment though on real hardware.
This was done using Claude Sonnet 4.5 with Github Copilot, in Visual Studio Code in Agent Mode, using https://github.com/CpuID/open-dynamic-export/blob/821d5ad7e1965ad9c0a88ae86f1569380ad1f142/BATTERY_IMPLEMENTATION.md as an input spec.