Battery Control Implementation #89
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @longzheng - thoughts direction wise...? |
Co-authored-by: CpuID <[email protected]>
…808a0d3b7c11 Fix missing battery fields in InverterControlLimit test objects and setpoints
Co-authored-by: CpuID <[email protected]>
Co-authored-by: CpuID <[email protected]>
Co-authored-by: CpuID <[email protected]>
- Add missing StorCtl_Mod.OFF enum value for battery storage control mode - Add all required nullable properties to StorageModel test objects - Update imports to include StorCtl_Mod enum - Replace literal values with proper enum values in test expectations - Addresses all TypeScript compilation errors from CI build Co-authored-by: CpuID <[email protected]>
…2f739918e0b8 Add comprehensive unit tests for battery control functionality
Contributor
Author
|
I'll look at the build failure next, looks fairly small. Also I want to check on the syntax for This all still needs a thorough review, that will also be next on my list to grasp that its doing what it's meant to... |
for a battery enabled sunspec inverter
Contributor
Author
|
Closing in favour of #98 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An AI generated attempt at fixing #68
Initially targets SunSpec only, but may be possible to extend to other inverters in future
I suspect this won't be 100% there, but maybe it provides a good foundation to solving this problem? :)
This was done using Claude 4 with Github Copilot, in Visual Studio Code in Agent Mode, with an extensive prompt explaining the problem + multiple interactive conversations of what the configuration syntax should look like.