Initial Commit

[raymolin]

Package was handed off from Brandon Tom after the edits to code review from Elastic were made.

[purbon]

Yay! welcome back and thanks for your contribution, I will start again the reviews in here 😺 keep talking!

[purbon]

As we used the new ruby based namespace model here, the logstash part of the class name Is a bit redundant, isn't?

[raymolin]

The implementation of these classes follows a convention that has been set when using KCL. I believe even if it's redundant, it's better to keep a consistent experience across our KCL applications.

[purbon]

@raymolin I've execute bundle exec rspec all test goes as expected, rspec reports:

purbon-elastic% 
purbon-elastic% bundle exec rspec
Using Accessor#strict_set for specs
Run options: exclude {:redis=>true, :socket=>true, :performance=>true, :couchdb=>true, :elasticsearch=>true, :elasticsearch_secure=>true, :export_cypher=>true, :integration=>true, :windows=>true}
.........log4j:WARN No appenders could be found for logger (com.amazonaws.AmazonWebServiceClient).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info.
...............

Finished in 0.886 seconds (files took 2.5 seconds to load)
24 examples, 0 failures

Randomized with seed 12758

^C
Exiting... Interrupt again to exit immediately.
^C%                                     

but it gets hanged by the end of the all execution, does this happen to you? might be a thread is waiting to be closed? multithreading with rspec can be super tricky.

[raymolin]

Will need to investigate the testing a little bit more... taken care of rest of comments

Update 08/25 - Doesn't seem to be a multi threading issue (dumped all threads at the end of each test), but have isolated the problem to the dynamodb.rb file (doesn't hang if this test isn't run). Not too familiar with the internals of this file, so I'll go ahead and look into it some more

Another update, the issue seems to stem from allow_invalid_credentials method in spec/inputs/dynamodb_spec.rb... Looks like it has something to do with when we register a new plugin... will continue to investigate.

[raymolin]

@purbon There seems to be an issue using mocha to mock explicit Java Objects. Do you have any thoughts on this? At this point, this seems to be a framework limitation that is blocking the release, even though the test themselves pass. Perhaps we could disable these tests by default and make a note discussing these limitations.

[elasticsearch-release]

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

[talevy]

@raymolin following up on this. did you ever get to signing our CLA?

[gulbinas]

👍

[Node0]

Was this merged in another PR? Did progress here stop?