[HWFlattenModules] Add support for verif.formal parent ops. #9984
Draft
[HWFlattenModules] Add support for verif.formal parent ops. #9984
verif.formal parent ops. #9984Conversation
Member
Author
|
It seems like the problem is that InstanceGraphs can only contain hw::HWModuleOp, I don't feel like it's a good idea to change anything in that since it seems quite load-bearing, maybe creating a more general instance graph that also allows for other "module like" ops could be useful here? |
Member
|
I think it's possible to add igraph::InstanceGraphOpInterface to FormalOp, but not 100% sure it's going to compose well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my attempt at adding support for having
verif.formalbe the parent of an instance to inline.This currently still doesn't do anything for some reason (but doesn't break the pass).
Any help or ideas are appreciated, particularly if @fabianschuiki has an idea, since I think this is originally your code.