Skip to content

[HWFlattenModules] Add support for verif.formal parent ops. #9984

Draft
dobios wants to merge 1 commit intomainfrom
dev/dobios/inline-formal-ops
Draft

[HWFlattenModules] Add support for verif.formal parent ops. #9984
dobios wants to merge 1 commit intomainfrom
dev/dobios/inline-formal-ops

Conversation

@dobios
Copy link
Copy Markdown
Member

@dobios dobios commented Mar 19, 2026

This is my attempt at adding support for having verif.formal be the parent of an instance to inline.
This currently still doesn't do anything for some reason (but doesn't break the pass).
Any help or ideas are appreciated, particularly if @fabianschuiki has an idea, since I think this is originally your code.

@dobios
Copy link
Copy Markdown
Member Author

dobios commented Mar 19, 2026

It seems like the problem is that InstanceGraphs can only contain hw::HWModuleOp, I don't feel like it's a good idea to change anything in that since it seems quite load-bearing, maybe creating a more general instance graph that also allows for other "module like" ops could be useful here?

@uenoku
Copy link
Copy Markdown
Member

uenoku commented Mar 19, 2026

I think it's possible to add igraph::InstanceGraphOpInterface to FormalOp, but not 100% sure it's going to compose well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants