[Handshake] Fix argument index tracking with multiple ext memref args#9978
Open
TopiLeppanen wants to merge 1 commit intollvm:mainfrom
Open
[Handshake] Fix argument index tracking with multiple ext memref args#9978TopiLeppanen wants to merge 1 commit intollvm:mainfrom
TopiLeppanen wants to merge 1 commit intollvm:mainfrom
Conversation
… args When `lowerExtmemToHW` processes a function with more than one external memref argument, each iteration inserts `addedInPorts` new block arguments and erases the original memref argument. Subsequent iterations need to take this into account. Fixes llvm#9807
Dinistro
reviewed
Mar 23, 2026
Contributor
Dinistro
left a comment
Dinistro
left a comment
There was a problem hiding this comment.
I don't know this code to well, so I would prefer if @mortbopet could review this.
Overall, this seems reasonable, though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I bumped into the issue #9807, and managed to fix it.
When
lowerExtmemToHWprocesses a function with more than one external memref argument, each iteration insertsaddedInPortsnew block arguments and erases the original memref argument. Subsequent iterations weren't taking this into account.