[FIRRTL] Emit memory initialization metadata#9974
Open
fzi-hielscher wants to merge 5 commits intollvm:mainfrom
Open
[FIRRTL] Emit memory initialization metadata#9974fzi-hielscher wants to merge 5 commits intollvm:mainfrom
fzi-hielscher wants to merge 5 commits intollvm:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve the
MemoryInitAttrwhen loweringfirrtl.memtofirrtl.memmoduleand emit the contained information during CreateSiFiveMetadata when using--repl-seq-mem. The attribute'sfilename,isBinaryandisInlinefields are forwarded to the OM and JSON output. The respective memory's line in the plain text output is appended withinit-bin {filename}orinit-hex {filename}, depending on theisBinaryfield. Note that the added information might break existing (legacy?) Chisel to Verilog flows if they are parsing the text file.Late follow-up to #8604, should fix #9959.