[LLHD] Use new combinational process instead of execute regions #8537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maerhart
approved these changes
Jun 5, 2025
fabianschuiki
force-pushed
the
fschuiki/use-comb-op
branch
from
21a3815 to
e9950a0
Compare
fabianschuiki
force-pushed
the
fschuiki/comb-op
branch
2 times, most recently
from
3c567f2 to
b53a013
Compare
fabianschuiki
force-pushed
the
fschuiki/use-comb-op
branch
from
e9950a0 to
4b6e824
Compare
uenoku
reviewed
Jun 5, 2025
| @@ -1222,14 +1223,14 @@ ValueRange Deseq::specializeProcess(FixedValues fixedValues) { | |||
| auto [oldBlock, newBlock] = worklist.pop_back_val(); | |||
| builder.setInsertionPointToEnd(newBlock); | |||
| for (auto &oldOp : *oldBlock) { | |||
| // Convert `llhd.wait` into `scf.yield`. | |||
| // Convert `llhd.wait` into `llhd.halt`. | |||
There was a problem hiding this comment.
No you're right, this should be llhd.yield. Thanks! 🙌
Make deseq and process lowering use the new `llhd.combinational` op instead of the existing `scf.execute_region`. The latter is too eager to inline into the parent region, even if the region contains ops with side effects such as probes and drives. These no longer have a clear order in the parent module. The specialized LLHD op is less eager about inlining and can deal with the details of the SSACFG-to-graph region transition in more detail. This commit is basically just a whole bunch of renaming and changing comments. No change intended besides the different op. Fixes #8532.
fabianschuiki
force-pushed
the
fschuiki/use-comb-op
branch
from
4b6e824 to
4b8b11a
Compare
fabianschuiki
force-pushed
the
fschuiki/comb-op
branch
from
b53a013 to
b01930c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make deseq and process lowering use the new
llhd.combinationalop instead of the existingscf.execute_region. The latter is too eager to inline into the parent region, even if the region contains ops with side effects such as probes and drives. These no longer have a clear order in the parent module. The specialized LLHD op is less eager about inlining and can deal with the details of the SSACFG-to-graph region transition in more detail.This commit is basically just a whole bunch of renaming and changing comments. No change intended besides the different op.
Fixes #8532.