Skip to content

Conditonally add external attribute for memory element #10050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abhilekhgautam wants to merge 2 commits into
base: main
Choose a base branch
from
+20 −2
Open

Conditonally add external attribute for memory element #10050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fd29ed
fix: set external attribute for memory only on top level component
Abhilekhgautam Mar 26, 2026
0989719
fix: don't emit external(0)
Abhilekhgautam Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions lib/Conversion/SCFToCalyx/SCFToCalyx.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,19 @@
#include "mlir/Pass/Pass.h"
#include "mlir/Support/LogicalResult.h"
#include "mlir/Transforms/GreedyPatternRewriteDriver.h"
#include "llvm/ADT/APInt.h"
#include "llvm/ADT/TypeSwitch.h"
#include "llvm/BinaryFormat/MsgPackReader.h"
#include "llvm/Support/LogicalResult.h"
#include "llvm/Support/NativeFormatting.h"
#include "llvm/Support/raw_os_ostream.h"
#include "llvm/Support/raw_ostream.h"
#include <algorithm>
#include <filesystem>
#include <fstream>

#include <locale>
#include <mlir/IR/BuiltinAttributes.h>
#include <numeric>
#include <variant>

Expand Down Expand Up @@ -1301,10 +1305,19 @@ static LogicalResult buildAllocOp(ComponentLoweringState &componentState,
rewriter, allocOp.getLoc(), componentState.getUniqueName("mem"),
memtype.getElementType().getIntOrFloatBitWidth(), sizes, addrSizes);

auto componentOp = componentState.getComponentOp();

// Externalize memories conditionally (only in the top-level component because
// Calyx compiler requires it as a well-formness check).
memoryOp->setAttr("external",
IntegerAttr::get(rewriter.getI1Type(), llvm::APInt(1, 1)));
if (componentOp->hasAttr("toplevel")) {
memoryOp->setAttr(
"external", IntegerAttr::get(rewriter.getI1Type(), llvm::APInt(1, 1)));

} else {
memoryOp->setAttr(
"external", IntegerAttr::get(rewriter.getI1Type(), llvm::APInt(1, 0)));
}

componentState.registerMemoryInterface(allocOp.getResult(),
calyx::MemoryInterface(memoryOp));

Expand Down
5 changes: 5 additions & 0 deletions lib/Dialect/Calyx/Export/CalyxEmitter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,10 @@ struct Emitter {
if (!atFormat) {
buffer << quote() << identifier << quote() << equals() << value;
} else {
// don't emit external(0)
if (identifier == "external" && intAttr.getValue() == 0) {
return "";
}
buffer << addressSymbol() << identifier;
// The only time we may omit the value is when it is a Boolean attribute
// with value 1.
Expand Down Expand Up @@ -875,6 +879,7 @@ void Emitter::emitSeqMemory(SeqMemoryOp memory) {
"supported by the native Calyx compiler.");
return;
}

bool isRef = !memory->hasAttr("external");
indent();
if (isRef)
Expand Down