[FIRRTL] Improve domain port naming in InferDomains pass#10037
Draft
[FIRRTL] Improve domain port naming in InferDomains pass#10037
Conversation
Inferred domain ports are now named based on their origin (instance name and port name) rather than just the domain type name. This makes it easier to trace where domains come from in the design. For example, a domain port that originates from instance 'bar' port 'A' is now named 'bar_A' instead of 'ClockDomain' or 'ClockDomain_0'. This change tracks domain origins through the unification process and uses them when generating port names, falling back to the domain type name when no origin is available. AI-assisted-by: Augment (Claude Sonnet 4.5) Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inferred domain ports are now named based on their origin (instance name
and port name) rather than just the domain type name. This makes it
easier to trace where domains come from in the design.
For example, a domain port that originates from instance 'bar' port 'A'
is now named 'bar_A' instead of 'ClockDomain' or 'ClockDomain_0'.
This change tracks domain origins through the unification process and
uses them when generating port names, falling back to the domain type
name when no origin is available.
AI-assisted-by: Augment (Claude Sonnet 4.5)