-
-
Notifications
You must be signed in to change notification settings - Fork 615
Web-Token Suite 4.0 support #1231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.x
Are you sure you want to change the base?
Conversation
|
@Spomky do you plan to add support for remote jwksets or is there any way to make this bundle retrieve them like how it was with Spomky-Labs/lexik-jose-bridge |
|
Any idea when this might get merged? |
| } | ||
| if ($config['access_token_verification']['enabled'] === true) { | ||
| $loader->load('web_token_verification.xml'); | ||
| $phpLoader = new PhpFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should migrate the whole configuration at once if we want to change it in the bundle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted. I reverted the changes
|
Hello, what is the status of this PR? It would be great if this could be merged in order to support the newest version. Thanks. |
|
any updates? would be nice to have this merged, thank you! |
|
Any updates please? |
|
@chalasr any information on when this will be merged? |
|
I would need @Spomky to rebase this PR in order to see if there is more to be done, the sooner it's merged the better. |
85376d0 to
7308622
Compare
|
For information, the failed test related to validator should be fix in the next release of API Platform, see : api-platform/core#7296 |
|
|
Maybe we can do something like that in the require-dev |
|
Now that api-platform/core#7296 is merged, I guess the CI just needs to be triggered again? |
|
@Spomky any chance you could trigger the CI again, now that the PR we were waiting for has been merged? |
This PR allows the use of the Web Token Suite new major release 4.0