-
Notifications
You must be signed in to change notification settings - Fork 2
🚸 Set up Django on every import of lamindb via a "mock instance" #1063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
falexwolf
wants to merge
41
commits into
main
Choose a base branch
from
alwaysconnect
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
af6b699
🚸 Always connect
falexwolf 4b1f6eb
💚 Fixes
falexwolf 7c9e90e
Merge branch 'main' into alwaysconnect
falexwolf 33f5962
💚 Fix
falexwolf bd2959f
💚 Fix
falexwolf be500f9
♻️ Changes
falexwolf ee18546
💚 Fixes
falexwolf 7784168
🐛 Auto-connect is always True now
falexwolf c5ea1d9
Merge branch 'main' into alwaysconnect
falexwolf 0ed9adb
♻️ Also reset variables upon lamin init
falexwolf b917568
💚 Mock instance needs to have all modules
falexwolf 93599e2
💚 Fixes
falexwolf 8e8e930
🚧 Try outs along the lines of not setting up Django using lamindb as …
falexwolf 8057031
Revert "🚧 Try outs along the lines of not setting up Django using lam…
falexwolf 655f869
♻️ Configure apps_ready
falexwolf 386f6ae
Merge branch 'main' into alwaysconnect
falexwolf 7b42678
🚸 Raise CurrentInstanceNotConfigured error
falexwolf 23ac680
♻️ Fix issue
falexwolf fad092a
💚 Fix
falexwolf 31c3ea5
💚 Fix
falexwolf 17cd576
📝 Document error
falexwolf 7523b97
♻️ Also account for confest module
falexwolf 6b7fd9a
♻️ Add a warning about auto-connect
falexwolf d6fcf72
♻️ Remove switching auto-connect in init
falexwolf 233b829
♻️ We no longer need to gate on auto-connect
falexwolf eacbf28
♻️ Update is_connected()
falexwolf 5b91fd8
🚸 Prettier error message
falexwolf 57b6c7f
♻️ Move logging into more meaningful spot
falexwolf e9702c9
💚 Fix test
falexwolf 00d6cef
💚 Fix
falexwolf dbce392
♻️ Auto-detect candidate modules
falexwolf ea8ffda
♻️ Refactor
falexwolf 5b3b2a0
💚 Fix
falexwolf 4f96599
💚 Fix
falexwolf a943bcc
♻️ Also update classes
falexwolf 5db764a
Merge branch 'main' into alwaysconnect
falexwolf 6b57b26
✨ Allow re-connecting through re-configuring Django in the same Pytho…
falexwolf afc7711
Merge branch 'main' into alwaysconnect
falexwolf 5f05262
💚 Fix
falexwolf b2a1f92
🚨 Fix
falexwolf bd871f0
Merge branch 'main' into alwaysconnect
falexwolf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think it should always reset, it should do the reset only on re-connect. Also not clear why
importlib.reload
deosn't do this already.