🚸 Set up Django on every import of lamindb via a "mock instance" #1063
+154
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1063 +/- ##
==========================================
- Coverage 85.58% 85.47% -0.11%
==========================================
Files 45 45
Lines 3905 3953 +48
==========================================
+ Hits 3342 3379 +37
- Misses 563 574 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
falexwolf
changed the title
falexwolf
changed the title
falexwolf
changed the title
falexwolf
changed the title
Koncopd
reviewed
Jun 30, 2025
Koncopd
reviewed
Jun 30, 2025
| @@ -339,6 +340,7 @@ def init( | |||
| if _write_settings: | |||
| settings.auto_connect = True | |||
| importlib.reload(importlib.import_module("lamindb")) | |||
| reset_django_module_variables() | |||
There was a problem hiding this comment.
i don't think it should always reset, it should do the reset only on re-connect. Also not clear why importlib.reload deosn't do this already.
|
I think that very likely we can also eliminate the whole But these simplifications can also go into another PR, I guess. 🤔 |
…n process (#1077) * Allow to re-connect in the same process * allow to init * fix * correct test --------- Co-authored-by: Koncopd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change here should allow us to eliminate the conditional import in the lamindb root module.
This PR fixes several issues with the reset logic introduced here:
Stale class issue: https://claude.ai/share/b4b3dcb5-4685-42dc-8e32-50851d41c5ac