Skip to content

Conversation

@mrueg
Copy link
Member

@mrueg mrueg commented Apr 22, 2024

What this PR does / why we need it:
Cronjob is not timezone aware.
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Adds one label to the kube_cronjob_info metric.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2206

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 22, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 22, 2024
@mrueg mrueg force-pushed the cronjob-add-timezone branch from 831db76 to be6fc00 Compare April 22, 2024 08:17
@mrueg mrueg changed the title feat: Add timezone to kube_cronjob_info WIP: feat: Add timezone to kube_cronjob_info Apr 22, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 22, 2024
@mrueg mrueg force-pushed the cronjob-add-timezone branch from 1bb6417 to cd08464 Compare April 22, 2024 17:09
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 22, 2024
@mrueg mrueg force-pushed the cronjob-add-timezone branch from cd08464 to 98daf12 Compare April 22, 2024 18:03
@mrueg mrueg changed the title WIP: feat: Add timezone to kube_cronjob_info feat: Add timezone to kube_cronjob_info Apr 22, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 22, 2024
@mrueg mrueg changed the title feat: Add timezone to kube_cronjob_info feat: Add timezone to kube_cronjob_info / Make kube_cronjob_next_schedule_time timezone-aware Apr 22, 2024
@mrueg mrueg force-pushed the cronjob-add-timezone branch 2 times, most recently from 6b1fa06 to 35252bd Compare April 22, 2024 18:23
@mrueg mrueg force-pushed the cronjob-add-timezone branch from 35252bd to 569e820 Compare April 22, 2024 21:16
@logicalhan
Copy link
Member

/triage accepted
/assign @dgrisonnet

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 2, 2024
@mrueg mrueg added this to the v2.13.0 milestone Jun 14, 2024
@mrueg
Copy link
Member Author

mrueg commented Jul 15, 2024

@dgrisonnet @rexagod anything left to do to get this change in?

@mrueg mrueg removed this from the v2.13.0 milestone Jul 17, 2024
@der-eismann
Copy link
Contributor

@dgrisonnet @rexagod Sorry for the ping, but this feature is pretty important to us since we can't set the timezone on AWS' Bottlerocket OS. Is there any way to accelerate the review process?

@chlunde
Copy link
Contributor

chlunde commented Oct 20, 2024

@dgrisonnet maybe we could merge this without the info label, and then have a separate PR for the label?

Also linking to #500, I wrote more or less the same PR to fix that issue, which I believe have the same root cause

@mrueg
Copy link
Member Author

mrueg commented Nov 14, 2024

@dgrisonnet if you agree with #2528 and your time permits, can you help me get this merged? :)

Copy link
Member

@dgrisonnet dgrisonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, mrueg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ea5826a into kubernetes:main Nov 14, 2024
1 check passed
@mrueg mrueg added this to the v2.15.0 milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kube_cronjob_next_schedule_time in the past when cronjob timezone specified

7 participants