-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: Add timezone to kube_cronjob_info / Make kube_cronjob_next_schedule_time timezone-aware #2376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
831db76 to
be6fc00
Compare
1bb6417 to
cd08464
Compare
cd08464 to
98daf12
Compare
6b1fa06 to
35252bd
Compare
35252bd to
569e820
Compare
|
/triage accepted |
|
@dgrisonnet @rexagod anything left to do to get this change in? |
|
@dgrisonnet @rexagod Sorry for the ping, but this feature is pretty important to us since we can't set the timezone on AWS' Bottlerocket OS. Is there any way to accelerate the review process? |
|
@dgrisonnet maybe we could merge this without the info label, and then have a separate PR for the label? Also linking to #500, I wrote more or less the same PR to fix that issue, which I believe have the same root cause |
|
@dgrisonnet if you agree with #2528 and your time permits, can you help me get this merged? :) |
dgrisonnet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, mrueg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Cronjob is not timezone aware.
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Adds one label to the kube_cronjob_info metric.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2206