Skip to content

Conversation

@L3n41c
Copy link
Member

@L3n41c L3n41c commented Aug 8, 2025

What does this PR do?

Backport kubernetes/kube-state-metrics#2376.

Motivation

Fix timezone support for CronJobs in KSM check.

Describe how you validated your changes

https://dddev.datadoghq.com/notebook/12874571/-cons-7514-cronjob-metric-does-not-adjust-to-timezone?range=172800000&view=view-mode&start=1754512233566&live=true

image

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Aug 8, 2025
@L3n41c L3n41c added team/containers qa/done QA done before merge and regressions are covered by tests labels Aug 8, 2025
@L3n41c L3n41c force-pushed the lenaic/CONS-7514 branch from 7f0a9a7 to 2d6dfaa Compare August 8, 2025 21:02
@L3n41c L3n41c requested a review from a team as a code owner August 8, 2025 21:02
@L3n41c L3n41c requested a review from Copilot August 8, 2025 21:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the kube-state-metrics dependency to fix timezone support for CronJob monitoring in the Kubernetes State check. The change includes updating the replace directive in go.mod to point to a newer version of the forked kube-state-metrics repository that includes timezone fixes for CronJobs.

  • Updates kube-state-metrics version to include timezone fix for CronJobs
  • Adds release notes documenting the fix for the cronjob.on_schedule_check service check

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
go.mod Updates the replace directive for kube-state-metrics to a newer version with timezone support
releasenotes-dca/notes/cronjob-timezone-b38a4f6e4a92490c.yaml Adds release notes documenting the CronJob timezone fix

@cit-pr-commenter
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 607c27ab-0f25-4af4-afa2-44a769335d42

Baseline: 4ae5769
Comparison: 7e4b6b9
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +3.93 [+0.79, +7.08] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +3.93 [+0.79, +7.08] 1 Logs
tcp_syslog_to_blackhole ingress throughput +1.99 [+1.93, +2.05] 1 Logs
quality_gate_logs % cpu utilization +0.96 [-1.81, +3.73] 1 Logs bounds checks dashboard
quality_gate_metrics_logs memory utilization +0.72 [+0.32, +1.12] 1 Logs bounds checks dashboard
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.66 [+0.62, +0.70] 1 Logs
quality_gate_idle_all_features memory utilization +0.25 [+0.21, +0.28] 1 Logs bounds checks dashboard
docker_containers_memory memory utilization +0.16 [+0.10, +0.22] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.07 [-0.53, +0.67] 1 Logs
file_tree memory utilization +0.07 [+0.03, +0.11] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.02] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.33, +0.32] 1 Logs
otlp_ingest_logs memory utilization -0.02 [-0.15, +0.10] 1 Logs
ddot_metrics memory utilization -0.02 [-0.14, +0.09] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.04 [-0.67, +0.58] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.05 [-0.65, +0.55] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.13 [-0.70, +0.45] 1 Logs
quality_gate_idle memory utilization -0.15 [-0.19, -0.11] 1 Logs bounds checks dashboard
otlp_ingest_metrics memory utilization -0.35 [-0.49, -0.21] 1 Logs
ddot_logs memory utilization -0.38 [-0.47, -0.28] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor 4ae5769

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${0}$$ $${701.38}$$ < $${704.84}$$ $${+0.01}$$ $${177.64}$$ < $${178.58}$$
agent_deb_amd64_fips $${0}$$ $${699.64}$$ < $${703.09}$$ $${+0.02}$$ $${176.96}$$ < $${178.12}$$
agent_heroku_amd64 $${0}$$ $${351.02}$$ < $${355.37}$$ $${+0}$$ $${94.67}$$ < $${95.72}$$
agent_msi $${+0}$$ $${975.34}$$ < $${980.61}$$ $${+0.01}$$ $${147.41}$$ < $${149.31}$$
agent_rpm_amd64 $${0}$$ $${701.37}$$ < $${704.83}$$ $${+0.03}$$ $${179.86}$$ < $${180.22}$$
agent_rpm_amd64_fips $${0}$$ $${699.63}$$ < $${703.08}$$ $${-0.04}$$ $${178.82}$$ < $${179.85}$$
agent_rpm_arm64 $${0}$$ $${690.3}$$ < $${694.74}$$ $${-0.01}$$ $${162.12}$$ < $${163.96}$$
agent_rpm_arm64_fips $${0}$$ $${688.61}$$ < $${693.05}$$ $${+0.02}$$ $${161.09}$$ < $${163.0}$$
agent_suse_amd64 $${0}$$ $${701.37}$$ < $${704.83}$$ $${+0.03}$$ $${179.86}$$ < $${180.22}$$
agent_suse_amd64_fips $${0}$$ $${699.63}$$ < $${703.08}$$ $${-0.04}$$ $${178.82}$$ < $${179.85}$$
agent_suse_arm64 $${0}$$ $${690.3}$$ < $${694.74}$$ $${-0.01}$$ $${162.12}$$ < $${163.96}$$
agent_suse_arm64_fips $${0}$$ $${688.61}$$ < $${693.05}$$ $${+0.02}$$ $${161.09}$$ < $${163.0}$$
docker_agent_amd64 $${0}$$ $${783.36}$$ < $${788.65}$$ $${-0}$$ $${269.97}$$ < $${272.01}$$
docker_agent_arm64 $${+0}$$ $${795.62}$$ < $${802.0}$$ $${-0}$$ $${256.75}$$ < $${259.7}$$
docker_agent_jmx_amd64 $${+0}$$ $${974.66}$$ < $${979.84}$$ $${+0}$$ $${339.03}$$ < $${340.95}$$
docker_agent_jmx_arm64 $${-0}$$ $${975.52}$$ < $${981.8}$$ $${+0.01}$$ $${321.78}$$ < $${324.65}$$
docker_cluster_agent_amd64 $${0}$$ $${214.43}$$ < $${214.5}$$ $${+0}$$ $${72.91}$$ < $${73.51}$$
docker_cluster_agent_arm64 $${0}$$ $${230.26}$$ < $${230.33}$$ $${+0}$$ $${69.14}$$ < $${69.77}$$
docker_cws_instrumentation_amd64 $${+0}$$ $${7.07}$$ < $${7.12}$$ $${+0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${0}$$ $${6.69}$$ < $${6.92}$$ $${-0}$$ $${2.71}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${0}$$ $${38.72}$$ < $${39.57}$$ $${-0}$$ $${14.95}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${-0}$$ $${37.42}$$ < $${38.2}$$ $${-0}$$ $${14.39}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${29.96}$$ < $${31.4}$$ $${+0}$$ $${7.89}$$ < $${8.95}$$
dogstatsd_deb_arm64 $${0}$$ $${28.54}$$ < $${29.97}$$ $${+0}$$ $${6.85}$$ < $${7.89}$$
dogstatsd_rpm_amd64 $${0}$$ $${29.96}$$ < $${31.4}$$ $${+0}$$ $${7.9}$$ < $${8.96}$$
dogstatsd_suse_amd64 $${0}$$ $${29.96}$$ < $${31.4}$$ $${+0}$$ $${7.9}$$ < $${8.96}$$
iot_agent_deb_amd64 $${0}$$ $${54.33}$$ < $${54.55}$$ $${+0}$$ $${13.68}$$ < $${14.45}$$
iot_agent_deb_arm64 $${0}$$ $${51.64}$$ < $${51.9}$$ $${+0}$$ $${11.85}$$ < $${12.63}$$
iot_agent_deb_armhf $${0}$$ $${51.17}$$ < $${51.42}$$ $${-0}$$ $${11.91}$$ < $${12.74}$$
iot_agent_rpm_amd64 $${0}$$ $${54.33}$$ < $${54.55}$$ $${+0}$$ $${13.7}$$ < $${14.47}$$
iot_agent_rpm_arm64 $${0}$$ $${51.17}$$ < $${51.91}$$ $${-0}$$ $${11.93}$$ < $${12.65}$$
iot_agent_suse_amd64 $${0}$$ $${54.33}$$ < $${54.55}$$ $${+0}$$ $${13.7}$$ < $${14.47}$$

@L3n41c
Copy link
Member Author

L3n41c commented Aug 11, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Aug 11, 2025

View all feedbacks in Devflow UI.

2025-08-11 10:01:30 UTC ℹ️ Start processing command /merge


2025-08-11 10:01:36 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 32m (p90).


2025-08-11 10:03:13 UTC ℹ️ MergeQueue: Readding this merge request to the queue because another merge request processed with yours failed. No action is needed from your side.


2025-08-11 11:33:17 UTCMergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for a149121:

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.
Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

@L3n41c L3n41c added this to the 7.71.0 milestone Aug 11, 2025
@L3n41c
Copy link
Member Author

L3n41c commented Aug 11, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Aug 11, 2025

View all feedbacks in Devflow UI.

2025-08-11 11:41:24 UTC ℹ️ Start processing command /merge


2025-08-11 11:41:30 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 33m (p90).


2025-08-11 11:47:11 UTC ℹ️ MergeQueue: Readding this merge request to the queue because another merge request processed with yours failed. No action is needed from your side.


2025-08-11 12:22:15 UTC ℹ️ MergeQueue: Readding this merge request to the queue because another merge request processed with yours failed. No action is needed from your side.


2025-08-11 12:54:09 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 42da451 into main Aug 11, 2025
245 checks passed
@dd-mergequeue dd-mergequeue bot deleted the lenaic/CONS-7514 branch August 11, 2025 12:54
@L3n41c L3n41c added the backport/7.70.x Automatically create a backport PR to 7.70.x label Aug 11, 2025
@agent-platform-auto-pr
Copy link
Contributor

The backport to 7.70.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.70.x 7.70.x
# Navigate to the new working tree
cd .worktrees/backport-7.70.x
# Create a new branch
git switch --create backport-39688-to-7.70.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 42da4510cc398ca6eb0cf2e3256e94120253169b
# Push it to GitHub
git push --set-upstream origin backport-39688-to-7.70.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.70.x

Then, create a pull request where the base branch is 7.70.x and the compare/head branch is backport-39688-to-7.70.x.

L3n41c added a commit that referenced this pull request Aug 11, 2025
Co-authored-by: Copilot <[email protected]>
(cherry picked from commit 42da451)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/7.70.x Automatically create a backport PR to 7.70.x qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/containers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants