-
Notifications
You must be signed in to change notification settings - Fork 355
(1.28) Automated cherry pick of #1146: upgraded to ec2 v2, buggy #1157: Update ELB and ELBV2 packages to AWS SDK Go V2 #1169: aws sdk go upgrade #1177: update aws & awserr to go sdk v2 #1296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-1.28
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This issue is currently awaiting triage. If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
f6aa6fd to
e19ca0b
Compare
Signed-off-by: Davanum Srinivas <[email protected]>
Signed-off-by: Min Jin <[email protected]>
Signed-off-by: Min Jin <[email protected]>
e21c9a7 to
df6a8fc
Compare
Signed-off-by: Min Jin <[email protected]>
df6a8fc to
24c4b53
Compare
|
Signed-off-by: Min Jin <[email protected]>
|
/test pull-cloud-provider-aws-e2e |
|
@yue9944882: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Cherry pick of #1146 #1157 #1169 #1177 on release-1.28.
#1146: upgraded to ec2 v2, buggy
#1157: Update ELB and ELBV2 packages to AWS SDK Go V2
#1169: aws sdk go upgrade
#1177: update aws & awserr to go sdk v2
Also manually applied changes to upgrade ECR and Autoscaling usage to aws sdk go v2. The changes to ECR are in files
cmd/ecr-credential-provider/main.go
cmd/ecr-credential-provider/main_test.go
pkg/mocks/mock_ecr.go
and the changes to autoscaling are in files
pkg/providers/v1/aws_sdk.go (client creation code)
pkg/providers/v1/config.go (helper functions for client creation)
For details on the cherry pick process, see the cherry pick requests page.