Skip to content

Conversation

@yue9944882
Copy link
Member

Cherry pick of #1146 #1157 #1169 #1177 on release-1.28.

#1146: upgraded to ec2 v2, buggy
#1157: Update ELB and ELBV2 packages to AWS SDK Go V2
#1169: aws sdk go upgrade
#1177: update aws & awserr to go sdk v2

Also manually applied changes to upgrade ECR and Autoscaling usage to aws sdk go v2. The changes to ECR are in files

cmd/ecr-credential-provider/main.go
cmd/ecr-credential-provider/main_test.go
pkg/mocks/mock_ecr.go
and the changes to autoscaling are in files
pkg/providers/v1/aws_sdk.go (client creation code)
pkg/providers/v1/config.go (helper functions for client creation)
For details on the cherry pick process, see the cherry pick requests page.

Migrate to AWS SDK Go V2

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 10, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign olemarkus for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 10, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 10, 2025
@yue9944882 yue9944882 changed the title Automated cherry pick of #1146: upgraded to ec2 v2, buggy #1157: Update ELB and ELBV2 packages to AWS SDK Go V2 #1169: aws sdk go upgrade #1177: update aws & awserr to go sdk v2 (1.28) Automated cherry pick of #1146: upgraded to ec2 v2, buggy #1157: Update ELB and ELBV2 packages to AWS SDK Go V2 #1169: aws sdk go upgrade #1177: update aws & awserr to go sdk v2 Nov 10, 2025
@yue9944882 yue9944882 force-pushed the 1.28-sdk-v2 branch 10 times, most recently from f6aa6fd to e19ca0b Compare November 10, 2025 23:18
@yue9944882 yue9944882 force-pushed the 1.28-sdk-v2 branch 3 times, most recently from e21c9a7 to df6a8fc Compare November 11, 2025 03:39
Signed-off-by: Min Jin <[email protected]>
@yue9944882
Copy link
Member Author

This version of Kubernetes is no longer supported; upgrading Kubernetes is required

@kmala
Copy link
Member

kmala commented Nov 12, 2025

/test pull-cloud-provider-aws-e2e

@k8s-ci-robot
Copy link
Contributor

@yue9944882: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cloud-provider-aws-e2e f2acb5b link true /test pull-cloud-provider-aws-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants