Skip to content

Commit df6a8fc

Browse files
committed
fixes rebase conflict
Signed-off-by: Min Jin <[email protected]>
1 parent bfdd869 commit df6a8fc

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

cmd/ecr-credential-provider/main.go

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ import (
3535

3636
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
3737
"k8s.io/component-base/logs"
38+
"k8s.io/klog/v2"
3839
v1 "k8s.io/kubelet/pkg/apis/credentialprovider/v1"
3940
)
4041

@@ -119,10 +120,7 @@ func (e *ecrPlugin) getPublicCredsData(ctx context.Context) (*credsData, error)
119120

120121
func (e *ecrPlugin) getPrivateCredsData(ctx context.Context, imageHost string, image string) (*credsData, error) {
121122
klog.Infof("Getting creds for private image %s", image)
122-
region, err := parseRegionFromECRPrivateHost(imageHost)
123-
if err != nil {
124-
return nil, err
125-
}
123+
var err error
126124
if e.ecr == nil {
127125
region := parseRegionFromECRPrivateHost(imageHost)
128126
e.ecr, err = defaultECRProvider(ctx, region)
@@ -225,12 +223,12 @@ func parseHostFromImageReference(image string) (string, error) {
225223
return parsed.Hostname(), nil
226224
}
227225

228-
func parseRegionFromECRPrivateHost(host string) (string, error) {
226+
func parseRegionFromECRPrivateHost(host string) string {
229227
splitHost := ecrPrivateHostPattern.FindStringSubmatch(host)
230228
if len(splitHost) != 5 {
231-
return "", fmt.Errorf("invalid private ECR host: %s", host)
229+
return ""
232230
}
233-
return splitHost[3], nil
231+
return splitHost[3]
234232
}
235233

236234
func main() {

0 commit comments

Comments
 (0)