-
Notifications
You must be signed in to change notification settings - Fork 164
Data cache support for K8s 1.31 #2106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-1.14
Are you sure you want to change the base?
Changes from all commits
6ecf0ff
27b866a
02c8534
8b4d9e1
040ec58
8f2a701
4212f84
723acf5
e1d8632
63d56ec
03d4a84
bc0a5d3
5233508
f86f20d
0c33c22
0cb814a
9aca35b
5b9665a
f04f496
a420e9d
3ffb6af
f22f043
daa3ff5
0df87d8
d142b88
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -49,8 +49,7 @@ metadata: | |
name: imagetag-gcepd-driver | ||
imageTag: | ||
name: gke.gcr.io/gcp-compute-persistent-disk-csi-driver | ||
# Don't change stable image without changing pdImagePlaceholder in | ||
# test/k8s-integration/main.go | ||
# pdImagePlaceholder in test/k8s-integration/main.go is updated automatically with the newTag | ||
newName: registry.k8s.io/cloud-provider-gcp/gcp-compute-persistent-disk-csi-driver | ||
newTag: "v1.13.2" | ||
newTag: "v1.13.3" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there here just for testing, or do we want to set it back for the current stable-master? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This value was set to v1.13.2 on the release 1.14 branch per: https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/release-1.14/deploy/kubernetes/images/stable-master/image.yaml One of the PRs I cherry picked most likely set this to a higher value and that's likely why it shows the diff from 1.17.2. On this release branch I believe it should be set to the release branch's stable master version right? |
||
--- |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
#!/bin/bash | ||
|
||
/bin/cp -r /lvm-tmp/lvm /etc/ | ||
/bin/sed -i -e "s/.*allow_mixed_block_sizes = 0.*/ allow_mixed_block_sizes = 1/" /etc/lvm/lvm.conf | ||
/bin/sed -i -e "s/.*udev_sync = 1.*/ udev_sync = 0/" /etc/lvm/lvm.conf | ||
/bin/sed -i -e "s/.*udev_rules = 1.*/ udev_rules = 0/" /etc/lvm/lvm.conf | ||
/bin/sed -i -e "s/.*locking_dir = .*/ locking_dir = \"\/tmp\"/" /etc/lvm/lvm.conf | ||
|
||
/gce-pd-csi-driver "$@" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pwschuurman I needed to add this node name == common.TestNode section here for e2e tests to pass. Please lmk if this is not the right approach for testing purposes.