Data cache support for K8s 1.31 #2106

cemakd · 2025-06-04T20:54:15Z

What type of PR is this?
/kind feature

What this PR does / why we need it:
Adds the required support in PDCSI driver to setup caching for PVCs using local SSDs.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add GKE only data cache feature support in PDCSI driver, it allows to set up LSSDs as caching layer for created PVCs.

NodeUnstageVolume.

…pporting LSSDs

…er errors when RAIDing fails

check for VG cleanup

alot of no-op logs for customer.

k8s-ci-robot · 2025-06-04T20:54:23Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cemakd
Once this PR has been reviewed and has the lgtm label, please assign sunnylovestiramisu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2025-06-04T20:54:25Z

Hi @cemakd. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

sunnylovestiramisu · 2025-06-04T20:57:47Z

/ok-to-test

cemakd · 2025-06-04T22:45:42Z

/retest

deploy/kubernetes/images/stable-master/image.yaml

Sneha-at · 2025-06-05T18:41:53Z

pkg/gce-pd-csi-driver/cache.go

+	return infoSlice[1], nil
+}
+
+func setupCaching(devicePath string, req *csi.NodeStageVolumeRequest, nodeId string) (string, error) {


@sunnylovestiramisu I know we wanted to expand some unit tests coverage too (I don't recollect exact scenarios) Do we add that as well in this PR?

We do not add tests to a backport usually, if we add we should add to master first
.

Reduce new image tag to below 1.14, bump it from 1.13.2 to 1.13.3 Replace return with continue so we don't break out of infinite loop

pwschuurman · 2025-06-30T19:26:41Z

deploy/kubernetes/images/stable-master/image.yaml

@@ -51,5 +51,5 @@ imageTag:
  name: gke.gcr.io/gcp-compute-persistent-disk-csi-driver
  # pdImagePlaceholder in test/k8s-integration/main.go is updated automatically with the newTag
  newName: registry.k8s.io/cloud-provider-gcp/gcp-compute-persistent-disk-csi-driver
-  newTag: "v1.17.2"
+  newTag: "v1.13.3"


Is there here just for testing, or do we want to set it back for the current stable-master?

This value was set to v1.13.2 on the release 1.14 branch per: https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/release-1.14/deploy/kubernetes/images/stable-master/image.yaml

One of the PRs I cherry picked most likely set this to a higher value and that's likely why it shows the diff from 1.17.2.

On this release branch I believe it should be set to the release branch's stable master version right?

pwschuurman · 2025-06-30T19:33:09Z

@cemakd Can you mention which PRs were backported to this branch?

Changes from overlaid commits (on top of cherry-picked commits from previous PRs): https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/pull/2106/files/f04f49634cd6134fadd9410dd4f286b4d6af947b..2929634ad1e7537419bc15055f6a0b3cb1a52f76

cemakd · 2025-07-01T18:04:07Z

@cemakd Can you mention which PRs were backported to this branch?

Changes from overlaid commits (on top of cherry-picked commits from previous PRs): https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/pull/2106/files/f04f49634cd6134fadd9410dd4f286b4d6af947b..2929634ad1e7537419bc15055f6a0b3cb1a52f76

The list of PRs that were backported:

…able. Conditionally enable data cache on test node pools to fix e2e tests

cemakd · 2025-07-01T20:05:56Z

cmd/gce-pd-csi-driver/main.go

+	if nodeName != common.TestNode { // disregard logic below when E2E testing.
+		dataCacheLSSDCount, err := driver.GetDataCacheCountFromNodeLabel(ctx, nodeName)
+		return dataCacheLSSDCount != 0, err
+	} else if nodeName == common.TestNode {


@pwschuurman I needed to add this node name == common.TestNode section here for e2e tests to pass. Please lmk if this is not the right approach for testing purposes.

cemakd · 2025-07-02T20:59:25Z

/retest-required

splitting to fix issues with strings.Split in case of multiple consecutive spaces

cemakd · 2025-07-18T22:09:25Z

/retest-required

k8s-ci-robot · 2025-07-19T00:11:31Z

@cemakd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019	`0df87d8`	link	false	`/test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2019`
pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2022	`0df87d8`	link	false	`/test pull-gcp-compute-persistent-disk-csi-driver-e2e-windows-2022`
pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration	`0df87d8`	link	true	`/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sneha-at and others added 20 commits June 4, 2025 17:28

Add support for data cache

6ecf0ff

fix test suite issue

27b866a

Update flags for data cache

02c8534

Add hdMachineType to e2e setup code

8b4d9e1

Implementing watcher & reboot stability for data cache to master branch.

040ec58

Return error for any Data Cache related code in NodeStageVolume &

8f2a701

NodeUnstageVolume.

update RAIDing and validation steps

4212f84

update test setup to avoid running Datacache setup on machines not su…

723acf5

…pporting LSSDs

update validation logic for Data Cache to distinguish user and non-us…

e1d8632

…er errors when RAIDing fails

Update error message for end users

63d56ec

Fix chunksize bug for large cache size in data cache

03d4a84

skip cache clean up for non-data cache PVCs

bc0a5d3

Add unit tests

5233508

Only run data cache watcher if a data cache nodepool exist & adding

f86f20d

check for VG cleanup

Fix logic bug while checking available LSSDs for RAIDing for Data Cache

0c33c22

fix outdated metadata error in watcher

0cb814a

update cache logic to calculate chunk size based on toatl cache

9aca35b

Update

5b9665a

remove GKE Data Cache Watcher regular event logs since it's generating

f04f496

alot of no-op logs for customer.

Resolving some bad merges, update to e2e test setup, mod vendor update

a420e9d

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 4, 2025

k8s-ci-robot requested review from amacaskill and tyuchn June 4, 2025 20:54

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 4, 2025

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 4, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 4, 2025

Fix main.go bad merge from the latest commit hash of Data cache PRs

3ffb6af

Sneha-at reviewed Jun 5, 2025

View reviewed changes

deploy/kubernetes/images/stable-master/image.yaml Outdated Show resolved Hide resolved

Sneha-at reviewed Jun 5, 2025

View reviewed changes

cemakd force-pushed the data-cache branch from e4839f2 to 61cd800 Compare June 11, 2025 17:56

Check for volume group existing before updating vg metadata

f22f043

Reduce new image tag to below 1.14, bump it from 1.13.2 to 1.13.3 Replace return with continue so we don't break out of infinite loop

cemakd force-pushed the data-cache branch from 61cd800 to f22f043 Compare June 11, 2025 18:48

pwschuurman reviewed Jun 30, 2025

View reviewed changes

Disabling data cache watcher by default if node details are not avail…

daa3ff5

…able. Conditionally enable data cache on test node pools to fix e2e tests

cemakd force-pushed the data-cache branch from 2929634 to daa3ff5 Compare July 1, 2025 19:16

cemakd commented Jul 1, 2025

View reviewed changes

Fix typo and use strings.Fields for whitespace

0df87d8

splitting to fix issues with strings.Split in case of multiple consecutive spaces

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Data cache support for K8s 1.31 #2106

Data cache support for K8s 1.31 #2106

cemakd commented Jun 4, 2025

Uh oh!

k8s-ci-robot commented Jun 4, 2025

Uh oh!

k8s-ci-robot commented Jun 4, 2025

Uh oh!

sunnylovestiramisu commented Jun 4, 2025

Uh oh!

cemakd commented Jun 4, 2025

Uh oh!

Uh oh!

Sneha-at Jun 5, 2025

Uh oh!

sunnylovestiramisu Jul 18, 2025 •

edited

Loading

Uh oh!

pwschuurman Jun 30, 2025

Uh oh!

cemakd Jul 1, 2025

Uh oh!

pwschuurman commented Jun 30, 2025

Uh oh!

cemakd commented Jul 1, 2025

Uh oh!

cemakd Jul 1, 2025

Uh oh!

cemakd commented Jul 2, 2025

Uh oh!

cemakd commented Jul 18, 2025

Uh oh!

k8s-ci-robot commented Jul 19, 2025

Uh oh!

Uh oh!

Data cache support for K8s 1.31 #2106

Are you sure you want to change the base?

Data cache support for K8s 1.31 #2106

Conversation

cemakd commented Jun 4, 2025

Uh oh!

k8s-ci-robot commented Jun 4, 2025

Uh oh!

k8s-ci-robot commented Jun 4, 2025

Uh oh!

sunnylovestiramisu commented Jun 4, 2025

Uh oh!

cemakd commented Jun 4, 2025

Uh oh!

Uh oh!

Sneha-at Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

sunnylovestiramisu Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pwschuurman Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

cemakd Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

pwschuurman commented Jun 30, 2025

Uh oh!

cemakd commented Jul 1, 2025

Uh oh!

cemakd Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

cemakd commented Jul 2, 2025

Uh oh!

cemakd commented Jul 18, 2025

Uh oh!

k8s-ci-robot commented Jul 19, 2025

Uh oh!

Uh oh!

sunnylovestiramisu Jul 18, 2025 •

edited

Loading