🌱 Added test cases for list.go and github.go #11937

irapandey · 2025-03-07T09:16:26Z

What this PR does / why we need it:
This PR adds unit tests for release note generator to add more coverage to non-covered functions

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

#11368

/area testing

k8s-ci-robot · 2025-03-07T09:16:36Z

Hi @irapandey. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

irapandey · 2025-03-07T09:18:34Z

Hey @chandankumar4 - Can you take a look here
Thanks 😄

chrischdi · 2025-03-14T08:54:34Z

/ok-to-test

chrischdi · 2025-03-25T14:14:39Z

Please take a look at the linter findings. As soon as they got fixed I'd take a look at this PR :-)

irapandey · 2025-03-29T14:32:01Z

/re-test

irapandey · 2025-04-04T04:52:11Z

Hey @chrischdi

I think the lint task failed due to some error in setup - can we have this re-run so you can review it?

Thanks 😄

chrischdi · 2025-04-07T06:45:25Z

👍 Triggered a rerun.

sivchari · 2025-04-12T10:32:08Z

hack/tools/release/notes/list_test.go

+			name: "Successful PR Listing",
+			fields: &githubFromToPRLister{
+				client: &githubClient{
+					repo: "kubernetes-sigs/kind",


How about using kubernetes-sigs/cluster-api ?
Probably, to use kind repository doesn't affect in the future, but to use cluster-api is more safety since the repo is itself.

chrischdi · 2025-04-14T11:14:40Z

hack/tools/release/notes/list_test.go

+		{
+			name: "Successful PR Listing",
+			fields: &githubFromToPRLister{
+				client: &githubClient{


Wondering if we should better use some mock client instead of reaching out to github on unit tests (rate-limiting could apply and make the test flaky)

I agree with @chrischdi
In this case, to reach out to GitHub generates possibility about flaky. For example, when some PR piles the commit in a short period of time, we'll met the rate limit error. Then it's not problem even if we use mock client since we know the result at this time. In the future, using mock might not be problem.

chrischdi · 2025-04-14T11:15:09Z

hack/tools/release/notes/list_test.go

+func Test_githubFromToPRLister_listPRs(t *testing.T) {
+	tests := []struct {
+		name    string
+		fields  *githubFromToPRLister


Suggested change

fields *githubFromToPRLister

lister *githubFromToPRLister

chrischdi · 2025-04-14T11:15:29Z

hack/tools/release/notes/list_test.go

+			l := &githubFromToPRLister{
+				client:  tt.fields.client,
+				fromRef: tt.fields.fromRef,
+				toRef:   tt.fields.toRef,
+				branch:  tt.fields.branch,
+			}
+			_, err := l.listPRs(tt.args)


Suggested change

l := &githubFromToPRLister{

client: tt.fields.client,

fromRef: tt.fields.fromRef,

toRef: tt.fields.toRef,

branch: tt.fields.branch,

}

_, err := l.listPRs(tt.args)

_, err := tt.lister.listPRs(tt.args)

sbueringer · 2025-05-09T05:12:46Z

@irapandey do you have time to address the findings?

irapandey · 2025-05-14T10:35:55Z

@chrischdi - Might have missed the updates here
looking into it immediately

irapandey · 2025-08-04T10:20:04Z

irapandey · 2025-08-04T10:22:18Z

irapandey · 2025-09-04T06:32:23Z

Hey @sbueringer

Could you take a look here please 😄

hack/tools/release/notes/list.go

hack/tools/release/notes/mock_github.go

chrischdi · 2025-10-07T08:14:49Z

/lgtm

k8s-ci-robot · 2025-10-07T08:14:58Z

LGTM label has been added.

Git tree hash: 31ed7e4fd5afbd303be4baf19f50d364fade4c8d

sbueringer · 2025-10-07T10:01:22Z

/assign

sbueringer · 2025-10-07T10:01:27Z

Will try to take a look soon

hack/tools/release/notes/list_test.go

hack/tools/release/notes/process.go

irapandey · 2025-10-13T08:09:56Z

Hey @sbueringer - I was on a short break - will make the changes today EOD

sbueringer · 2025-10-13T12:20:03Z

Thx!

/lgtm
/approve

k8s-ci-robot · 2025-10-13T12:20:10Z

LGTM label has been added.

Git tree hash: 77f07cd1886ff4ef306eb9b5b19ad15f91919a21

k8s-ci-robot · 2025-10-13T12:20:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 7, 2025

k8s-ci-robot requested review from Sunnatillo and hackeramitkumar March 7, 2025 09:16

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 7, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 14, 2025

irapandey force-pushed the test_case_release_note_list_github branch 2 times, most recently from 6b3dea8 to 8b3ece5 Compare March 29, 2025 14:28

sivchari reviewed Apr 12, 2025

View reviewed changes

chrischdi reviewed Apr 14, 2025

View reviewed changes

irapandey force-pushed the test_case_release_note_list_github branch from 580172b to 321b6c9 Compare May 14, 2025 12:07

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 14, 2025

irapandey force-pushed the test_case_release_note_list_github branch from 191ef1d to 833a876 Compare August 4, 2025 09:06

irapandey added 2 commits August 4, 2025 14:36

Added test cases for list.go and github.go

525afcc

Linting issues fixed

25ff8d8

irapandey force-pushed the test_case_release_note_list_github branch from 833a876 to af5cc62 Compare August 4, 2025 09:07

chrischdi reviewed Sep 4, 2025

View reviewed changes

hack/tools/release/notes/list.go Outdated Show resolved Hide resolved

chrischdi reviewed Sep 4, 2025

View reviewed changes

hack/tools/release/notes/mock_github.go Outdated Show resolved Hide resolved

chrischdi reviewed Sep 4, 2025

View reviewed changes

hack/tools/release/notes/mock_github.go Show resolved Hide resolved

PR Review changes

4b4459f

irapandey force-pushed the test_case_release_note_list_github branch from cf8c247 to 4b4459f Compare September 4, 2025 16:23

irapandey requested a review from chrischdi September 5, 2025 03:52

k8s-ci-robot assigned chrischdi Oct 7, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2025

k8s-ci-robot assigned sbueringer Oct 7, 2025

sbueringer added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. area/release Issues or PRs related to releasing labels Oct 9, 2025

sbueringer reviewed Oct 9, 2025

View reviewed changes

hack/tools/release/notes/list_test.go Outdated Show resolved Hide resolved

hack/tools/release/notes/process.go Outdated Show resolved Hide resolved

PR review changes

de9972c

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2025

k8s-ci-robot requested a review from sbueringer October 13, 2025 11:46

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2025

k8s-ci-robot merged commit 0a089bc into kubernetes-sigs:main Oct 13, 2025
18 checks passed

k8s-ci-robot added this to the v1.12 milestone Oct 13, 2025

🌱 Added test cases for list.go and github.go #11937

🌱 Added test cases for list.go and github.go #11937

Uh oh!

Conversation

irapandey commented Mar 7, 2025

Uh oh!

k8s-ci-robot commented Mar 7, 2025

Uh oh!

irapandey commented Mar 7, 2025

Uh oh!

chrischdi commented Mar 14, 2025

Uh oh!

chrischdi commented Mar 25, 2025

Uh oh!

irapandey commented Mar 29, 2025

Uh oh!

irapandey commented Apr 4, 2025

Uh oh!

chrischdi commented Apr 7, 2025

Uh oh!

sivchari Apr 12, 2025

Choose a reason for hiding this comment

Uh oh!

chrischdi Apr 14, 2025

Choose a reason for hiding this comment

Uh oh!

sivchari May 14, 2025

Choose a reason for hiding this comment

Uh oh!

chrischdi Apr 14, 2025

Choose a reason for hiding this comment

Uh oh!

sivchari May 14, 2025

Choose a reason for hiding this comment

Uh oh!

chrischdi Apr 14, 2025

Choose a reason for hiding this comment

Uh oh!

sbueringer commented May 9, 2025

Uh oh!

irapandey commented May 14, 2025

Uh oh!

irapandey commented Aug 4, 2025

Uh oh!

irapandey commented Aug 4, 2025

Uh oh!

irapandey commented Sep 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chrischdi commented Oct 7, 2025

Uh oh!

k8s-ci-robot commented Oct 7, 2025

Uh oh!

sbueringer commented Oct 7, 2025

Uh oh!

sbueringer commented Oct 7, 2025

Uh oh!

Uh oh!

Uh oh!

irapandey commented Oct 13, 2025

Uh oh!

sbueringer commented Oct 13, 2025

Uh oh!

k8s-ci-robot commented Oct 13, 2025

Uh oh!

k8s-ci-robot commented Oct 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants