Skip to content

Commit 4b4459f

Browse files
committed
PR Review changes
1 parent 262bdc1 commit 4b4459f

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

hack/tools/release/notes/mock_github.go renamed to hack/tools/release/notes/github_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// +build tools
33

44
/*
5-
Copyright 2023 The Kubernetes Authors.
5+
Copyright 2025 The Kubernetes Authors.
66
77
Licensed under the Apache License, Version 2.0 (the "License");
88
you may not use this file except in compliance with the License.

hack/tools/release/notes/list.go

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -46,16 +46,6 @@ func newGithubFromToPRLister(repo string, fromRef, toRef ref, branch string) *gi
4646
}
4747
}
4848

49-
// for testing purposes.
50-
func newGithubFromToPRListerWithClient(client githubClientInterface, fromRef, toRef ref, branch string) *githubFromToPRLister {
51-
return &githubFromToPRLister{
52-
client: client,
53-
fromRef: fromRef,
54-
toRef: toRef,
55-
branch: branch,
56-
}
57-
}
58-
5949
// listPRs returns the PRs merged between `fromRef` and `toRef` (included).
6050
// It lists all PRs merged in main in the configured branch in the date
6151
// range between fromRef and toRef (we include main because minor releases

hack/tools/release/notes/list_test.go

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,16 @@ import (
2626
. "github.com/onsi/gomega"
2727
)
2828

29+
// newGithubFromToPRListerWithClient is a helper function for testing purposes.
30+
// It creates a new githubFromToPRLister with the given client, fromRef, toRef and branch.
31+
func newGithubFromToPRListerWithClient(client githubClientInterface, fromRef, toRef ref, branch string) *githubFromToPRLister {
32+
return &githubFromToPRLister{
33+
client: client,
34+
fromRef: fromRef,
35+
toRef: toRef,
36+
branch: branch,
37+
}
38+
}
2939
func Test_buildSetOfPRNumbers(t *testing.T) {
3040
tests := []struct {
3141
name string

0 commit comments

Comments
 (0)