Skip to content

Conversation

@jimmysenior
Copy link

Ⅰ. Describe what this PR does

suport evict container of yarn nodemanager

finish the implements of function KillContainerByResource of copilot-agent

Ⅱ. Does this pull request fix one issue?

fixes #Use the secure port 10250 to retrieve all pods on the node, preventing reliance on the insecure port 10255 which may not be enabled on the machine.

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

when need use this feature, need merge pr of koordinator and charts also

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot koordinator-bot bot requested a review from zwzhang0107 May 28, 2025 08:32
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign zwzhang0107 after the PR has been reviewed.
You can assign the PR to them by writing /assign @zwzhang0107 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented May 28, 2025

Codecov Report

❌ Patch coverage is 96.32353% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.38%. Comparing base (658fb98) to head (8191d2f).

Files with missing lines Patch % Lines
pkg/copilot-agent/server/server.go 95.53% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
- Coverage   73.37%   67.38%   -5.99%     
==========================================
  Files           2        7       +5     
  Lines         353      834     +481     
==========================================
+ Hits          259      562     +303     
- Misses         77      229     +152     
- Partials       17       43      +26     
Flag Coverage Δ
unittests 67.38% <96.32%> (-5.99%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: jimmysenior <[email protected]>

Add:support-evict-yarn-container

Signed-off-by: jimmysenior <[email protected]>
@jimmysenior jimmysenior force-pushed the feature/support-evict-yarn-container branch from cd8bc80 to 8191d2f Compare July 10, 2025 02:22
"flag"
"k8s.io/client-go/rest"
"os"
"sigs.k8s.io/controller-runtime/pkg/client/config"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import格式需要调整一下

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants