-
Notifications
You must be signed in to change notification settings - Fork 8
Add:support-evict-yarn-container #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add:support-evict-yarn-container #99
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
==========================================
- Coverage 73.37% 67.38% -5.99%
==========================================
Files 2 7 +5
Lines 353 834 +481
==========================================
+ Hits 259 562 +303
- Misses 77 229 +152
- Partials 17 43 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6a62849 to
3c0770c
Compare
Signed-off-by: jimmysenior <[email protected]> Add:support-evict-yarn-container Signed-off-by: jimmysenior <[email protected]>
cd8bc80 to
8191d2f
Compare
| "flag" | ||
| "k8s.io/client-go/rest" | ||
| "os" | ||
| "sigs.k8s.io/controller-runtime/pkg/client/config" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import格式需要调整一下
Ⅰ. Describe what this PR does
suport evict container of yarn nodemanager
finish the implements of function KillContainerByResource of copilot-agent
Ⅱ. Does this pull request fix one issue?
fixes #Use the secure port 10250 to retrieve all pods on the node, preventing reliance on the insecure port 10255 which may not be enabled on the machine.
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
when need use this feature, need merge pr of koordinator and charts also
V. Checklist
make test