Skip to content

Conversation

@jimmysenior
Copy link

Ⅰ. Describe what this PR does

suport evict container of yarn nodemanager
when koordlet config --evict-by-copilot-agent=true,the memory evict and cpu evict will send requet to component of copilot-agent through socket ,which pod to be evicted is yarn nodemanager. And the actual logic of evict will finished on the component of opilot-agent.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

when need use this feature, need merge pr of yarn-copilot and charts also
koordinator-sh/yarn-copilot#99
koordinator-sh/charts#94

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign yihuifeng after the PR has been reviewed.
You can assign the PR to them by writing /assign @yihuifeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ZiMengSheng
Copy link
Member

@jimmysenior Build Failed

@ZiMengSheng
Copy link
Member

/assign @zwzhang0107

@saintube saintube changed the title Add:support evict yarn container koordlet: support evict yarn container May 29, 2025
@codecov
Copy link

codecov bot commented May 30, 2025

Codecov Report

Attention: Patch coverage is 69.56522% with 56 lines in your changes missing coverage. Please review.

Project coverage is 65.95%. Comparing base (73fa323) to head (442b1e7).

Files with missing lines Patch % Lines
.../qosmanager/plugins/copilot/mock_copilot_server.go 55.31% 16 Missing and 5 partials ⚠️
.../koordlet/qosmanager/plugins/cpuevict/cpu_evict.go 67.30% 11 Missing and 6 partials ⚠️
...let/qosmanager/plugins/memoryevict/memory_evict.go 71.42% 10 Missing and 2 partials ⚠️
...ordlet/qosmanager/plugins/copilot/copilot_agent.go 91.17% 1 Missing and 2 partials ⚠️
pkg/koordlet/qosmanager/qosmanager.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2460      +/-   ##
==========================================
+ Coverage   65.93%   65.95%   +0.02%     
==========================================
  Files         477      479       +2     
  Lines       56194    56351     +157     
==========================================
+ Hits        37049    37165     +116     
- Misses      16461    16486      +25     
- Partials     2684     2700      +16     
Flag Coverage Δ
unittests 65.95% <69.56%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jimmysenior jimmysenior closed this Jun 3, 2025
@jimmysenior jimmysenior deleted the feature/support-evict-yarn-container branch June 5, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants