-
Notifications
You must be signed in to change notification settings - Fork 392
koordlet: support evict yarn container #2460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: support evict yarn container #2460
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jimmysenior Build Failed |
|
/assign @zwzhang0107 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2460 +/- ##
==========================================
+ Coverage 65.93% 65.95% +0.02%
==========================================
Files 477 479 +2
Lines 56194 56351 +157
==========================================
+ Hits 37049 37165 +116
- Misses 16461 16486 +25
- Partials 2684 2700 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ⅰ. Describe what this PR does
suport evict container of yarn nodemanager
when koordlet config --evict-by-copilot-agent=true,the memory evict and cpu evict will send requet to component of copilot-agent through socket ,which pod to be evicted is yarn nodemanager. And the actual logic of evict will finished on the component of opilot-agent.
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
when need use this feature, need merge pr of yarn-copilot and charts also
koordinator-sh/yarn-copilot#99
koordinator-sh/charts#94
V. Checklist
make test