fix(sidecar): stop loops and surface re-auth message on invalid_grant#57
Draft
VishiATChoudhary wants to merge 1 commit intofix/54-clear-stale-sessionfrom
Draft
fix(sidecar): stop loops and surface re-auth message on invalid_grant#57VishiATChoudhary wants to merge 1 commit intofix/54-clear-stale-sessionfrom
VishiATChoudhary wants to merge 1 commit intofix/54-clear-stale-sessionfrom
Conversation
When the heartbeat or event-ingestion path receives an error wrapping
auth.ErrInvalidGrant, the sidecar now:
1. Prints a single stderr message telling the user to run
`kontext login` (guarded by sync.Once so duplicate triggers from
concurrent heartbeat + ingest paths don't spam).
2. Cancels the sidecar context to stop both loops cleanly.
The agent child process keeps running — users can finish their in-flight
work without telemetry and re-authenticate on next `kontext start`.
Transient errors (network, 5xx) still log and retry exactly as before;
only permanent auth failures trigger the new shutdown path.
For testability: the client field is now an unexported backendClient
interface (still satisfied by *backend.Client), and the heartbeat ticker
interval is a field on Server so tests can set it to a few milliseconds.
Closes #54
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
go test ./...go test -race ./...go vet ./...buf generateif protobuf or generated code changedRelease notes