fix(run): clear stale session from keychain on invalid_grant#56
Draft
VishiATChoudhary wants to merge 1 commit intofix/54-classify-invalid-grantfrom
Draft
fix(run): clear stale session from keychain on invalid_grant#56VishiATChoudhary wants to merge 1 commit intofix/54-classify-invalid-grantfrom
VishiATChoudhary wants to merge 1 commit intofix/54-classify-invalid-grantfrom
Conversation
When auth.RefreshSession returns ErrInvalidGrant (refresh token
permanently rejected), the token source now:
1. Calls auth.ClearSession() so the next `kontext start` forces a
fresh login instead of re-loading the dead session.
2. Latches a permanentlyFailed flag so subsequent calls short-circuit
without hitting the network again.
The returned error still wraps ErrInvalidGrant so upstream callers
(sidecar — next PR) can detect the permanent failure via errors.Is and
shut down their retry loops instead of spamming logs every 30 seconds.
Package-level refreshSession/clearSession variables provide injection
seams so tests never touch the real system keyring.
Refs #54
5 tasks
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
go test ./...go test -race ./...go vet ./...buf generateif protobuf or generated code changedRelease notes