Skip to content

Remove unnecessary PodioDataSvc from DataHandle and harmonize constructors #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 26, 2025
Merged

Remove unnecessary PodioDataSvc from DataHandle and harmonize constructors #321

merged 6 commits into from
May 26, 2025

Conversation

tmadlener
Copy link
Contributor

BEGINRELEASENOTES

  • Remove the usage of PodioDataSvc from the DataHandle as it's not necessary
  • Harmonize the behavior of the constructors
  • Remove the declaration of the unimplemented default constructor

ENDRELEASENOTES

This is another coherent set of changes dropping out of #318

@tmadlener tmadlener mentioned this pull request May 22, 2025
Open
2 tasks
jmcarcell
jmcarcell reviewed May 26, 2025
View reviewed changes
jmcarcell
jmcarcell reviewed May 26, 2025
View reviewed changes
jmcarcell
jmcarcell reviewed May 26, 2025
View reviewed changes
@jmcarcell jmcarcell merged commit cd12ba6 into key4hep:main May 26, 2025
4 of 6 checks passed
jmcarcell added a commit that referenced this pull request Jun 4, 2025
@jmcarcell
Revert "Remove unnecessary PodioDataSvc from DataHandle and harmonize…
ca68073 
… constructors (#321)"

This reverts commit cd12ba6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcarcell jmcarcell jmcarcell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmadlener @jmcarcell