-
Notifications
You must be signed in to change notification settings - Fork 28
[WIP] Deprecate the PodioDataSvc and friends #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Could we also deprecate |
Up for discussion IMO. Technically the |
Then what is the correct approach to use collection metadata in functional algorithms? They don't have any data-handles there that could be passed to metadata-handles |
During meeting we discussed that collection metadata in functional algorithms is a separate issue. We won't deprecate the metadata-handles here. |
2196906
to
62ce3ad
Compare
Strategic question: How do we want to do the phaseout here? Until we fully remove the Some of the warnings in k4FWCore builds could probably be fixed with some pre-processor toggling of |
Should be possible to deal with all of this with Gaudi commodities now
62ce3ad
to
d28c819
Compare
BEGINRELEASENOTES
PodioDataSvc
(andk4DataSvc
andFCCDataSvc
) as well as thePodioInput
,PodioOutput
.WARNING
messages at runtime to inform users about the upcoming removal.ENDRELEASENOTES
This is the first and easy part of deprecating the
PodioDataSvc
(see #292). Moving to non-deprecated versions wherever possible internally still needs to be done. I think it should be possible to implement thek4FWCore::DataHandle
without the need of a customDataWrapper
that relies on thePodioDataSvc
. The idea is to place things going through thek4FWCore::DataHandle
into the TES the same way as theIOSvc
/ Functional utils do. That way Functional and non Functional algorithms should integrate seamlessly.