Skip to content

Fix failed tests #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Xiangs18 merged 11 commits into from
Jun 20, 2025
Merged

Fix failed tests #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
071451f
display user names
Xiangs18 Jun 18, 2025
7c44884
change user name
Xiangs18 Jun 18, 2025
d254563
fix incorrect auth2 user name
Xiangs18 Jun 18, 2025
97ec429
update auth url
Xiangs18 Jun 18, 2025
8357457
https://ci.kbase.us/services/auth/
Xiangs18 Jun 18, 2025
140d9da
revert back
Xiangs18 Jun 18, 2025
968aa64
fix constructFailBadUrl200
Xiangs18 Jun 20, 2025
60b9d3f
update text
Xiangs18 Jun 20, 2025
aa03913
update text length
Xiangs18 Jun 20, 2025
279ca5d
use real newlines and quotes
Xiangs18 Jun 20, 2025
ef65021
revert back text length
Xiangs18 Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
sed -i "s#^auth_token1 =.*#auth_token1 = $KBASE_CI_TOKEN#" test.cfg
sed -i "s#^auth_token2 =.*#auth_token2 = $KBASE_CI_TOKEN2#" test.cfg
sed -i "s#^auth_user1 =.*#auth_user1 = kbase_bot#" test.cfg
sed -i "s#^auth_user2 =.*#auth_user2 = sychan168#" test.cfg
sed -i "s#^auth_user2 =.*#auth_user2 = local_kbase_bot#" test.cfg
sed -i "s#^good_users =.*#good_users = kbasetest2 , kbasetest7 , kbasehelp#" test.cfg

./gradlew test
Expand Down
8 changes: 4 additions & 4 deletions src/test/java/us/kbase/test/auth/client/AuthClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,12 @@ public void constructFailNullURI() throws Exception {
@Test
public void constructFailBadUrl200() throws Exception {
// this test is fragile, the exception message might need tweaking
final String text = "<!doctype html><html lang=\"en\"><head>"
+ "<script async src=\"https://www.googletagmanager.com/gtag/js?...";
final String err = "Failed reading from auth url https://ci.kbase.us/services/authx/ "
final String text = "<!doctype html>\n<html>\n<head>\n "
+ "<title>Example Domain</title>\n\n <meta charset=\"utf-8\" />\n ...";
final String err = "Failed reading from auth url https://example.org "
+ "with response code 200 - response is not JSON: " + text;
assertThat("text is too long", text.length(), is(100));
failConstruct(new URI("https://ci.kbase.us/services/authx/"), new AuthException(err));
failConstruct(new URI("https://example.org"), new AuthException(err));
assertThat("no logs", LOGS.isEmpty(), is(true));
}

Expand Down