-
Notifications
You must be signed in to change notification settings - Fork 1
Fix failed tests #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failed tests #18
Conversation
|
@MrCreosote, is your auth URL up to date? If so, it's currently returning a 404 instead of the expected 200. |
|
How bad KBase urls under serivces/ are handled have changed - they now return 404 vs 200 (whichi is good). Try https://ci.kbase.us/serivce/auth instead, that should still return a 200 with unparseable json |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #18 +/- ##
==========================================
Coverage 92.38% 92.38%
Complexity 111 111
==========================================
Files 9 9
Lines 289 289
Branches 48 48
==========================================
Hits 267 267
Misses 20 20
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Ah, it failed on Java 8 but passed on Java 11. |
|
need to make the test deterministic :) |
|
Might be a blip since it got a 403, I restarted the test |
|
Well that makes no sense |
|
Looks like we might be hitting this: https://www.zenrows.com/blog/cloudflare-error-1010 |
|
Total guess, but maybe the java 8 test and java 11 test user agent headers are different enough such that cloudflare complains about 8 only |
|
Hold on, that won't test the truncation, crap |
|
https://www.kbase.us/ might work |
|
... except that'll probably get the cloudflare error. What we need is a url that won't get hit by that, has a longish non-json body, and returns 200 |
|
This seems to hit the spot: https://example.org |
No description provided.