Skip to content

Conversation

@Xiangs18
Copy link
Contributor

No description provided.

@Xiangs18
Copy link
Contributor Author

@MrCreosote, is your auth URL up to date? If so, it's currently returning a 404 instead of the expected 200.
https://github.com/kbase/auth2_client_java/actions/runs/15744652080/job/44378194368?pr=18#step:4:118

@MrCreosote
Copy link
Member

How bad KBase urls under serivces/ are handled have changed - they now return 404 vs 200 (whichi is good). Try https://ci.kbase.us/serivce/auth instead, that should still return a 200 with unparseable json

@codecov
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.38%. Comparing base (7e43944) to head (ef65021).
Report is 12 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #18   +/-   ##
==========================================
  Coverage      92.38%   92.38%           
  Complexity       111      111           
==========================================
  Files              9        9           
  Lines            289      289           
  Branches          48       48           
==========================================
  Hits             267      267           
  Misses            20       20           
  Partials           2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Xiangs18
Copy link
Contributor Author

Ah, it failed on Java 8 but passed on Java 11.

@Xiangs18
Copy link
Contributor Author

need to make the test deterministic :)

@MrCreosote
Copy link
Member

Might be a blip since it got a 403, I restarted the test

@MrCreosote
Copy link
Member

Well that makes no sense

@MrCreosote
Copy link
Member

Looks like we might be hitting this: https://www.zenrows.com/blog/cloudflare-error-1010

@MrCreosote
Copy link
Member

Try http://httpstat.us/200

@MrCreosote
Copy link
Member

Total guess, but maybe the java 8 test and java 11 test user agent headers are different enough such that cloudflare complains about 8 only

@MrCreosote
Copy link
Member

Hold on, that won't test the truncation, crap

@MrCreosote
Copy link
Member

https://www.kbase.us/ might work

@MrCreosote
Copy link
Member

... except that'll probably get the cloudflare error. What we need is a url that won't get hit by that, has a longish non-json body, and returns 200

@MrCreosote
Copy link
Member

This seems to hit the spot: https://example.org

@Xiangs18 Xiangs18 requested a review from MrCreosote June 20, 2025 19:38
@Xiangs18 Xiangs18 merged commit 3421886 into develop Jun 20, 2025
7 checks passed
@Xiangs18 Xiangs18 deleted the dev-fix_tests branch June 20, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants