Verify hot_reload crate handles relative path resolution for dependent files #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review comment questioned whether
dependent_paths()should resolve relative paths usingenv::current_dir()to matchplugins.rsbehavior. Investigation confirms the hot_reload crate already handles this internally.Findings
The hot_reload crate's
resolve_dependency_path()resolves relative paths against the parent directory of the config file, not the current working directory:Conclusion
Current implementation in
target_config.rsis correct -dependent_paths()returns paths as-is viaPathBuf::from(). The crate handles resolution internally, making paths relative to config file location rather than working directory. This is more robust thanenv::current_dir()approach.No code changes required.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.