feat: support realtime config+block+allow files reloading #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the configuration file watching mechanism from polling-only to a hybrid mode (combining file system events with polling) by upgrading the hot_reload library from version 0.3.4 to 0.3.5 and implementing the necessary AsyncFileLoad trait.
- Upgraded
hot_reloaddependency to version 0.3.5 - Switched from polling-based to hybrid file watching mode for more responsive configuration reloading
- Implemented
AsyncFileLoadtrait to support async configuration loading and dependent file tracking
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| proxy-bin/Cargo.toml | Upgraded hot_reload dependency from 0.3.4 to 0.3.5 |
| proxy-bin/src/main.rs | Changed reloader configuration from polling to hybrid mode and updated service start method |
| proxy-bin/src/config/target_config.rs | Implemented AsyncFileLoad trait with async loading and dependent paths tracking for plugin files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@junkurihara I've opened a new pull request, #78, to work on those changes. Once the pull request is ready, I'll request review from you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.