Skip to content

fix: reset price fields when switching to Octopus provider #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pookey wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: reset price fields when switching to Octopus provider #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion frontend/src/components/settings/PricingFormSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,16 @@ export function PricingFormSection({ form, onChange }: Props) {
const isOctopus = form.provider === 'octopus';
const currency = isOctopus ? 'GBP' : form.currency;

const handleChange = (next: PricingForm) => {
// When switching TO Octopus, reset fields that are hidden but still sent to
// the backend. Octopus rates are already all-in (VAT-inclusive, GBP/kWh),
// so markup / VAT / additional costs must be zero / neutral.
if (next.provider === 'octopus' && form.provider !== 'octopus') {
next = { ...next, markupRate: 0, vatMultiplier: 1, additionalCosts: 0 };
}
onChange(next);
};

const previewSpot = 1.0;
const previewBuy = Number(
((previewSpot + form.markupRate) * form.vatMultiplier + form.additionalCosts).toFixed(4),
Expand All @@ -46,7 +56,7 @@ export function PricingFormSection({ form, onChange }: Props) {
{ value: 'octopus', label: 'Octopus Energy' },
],
form.provider,
v => onChange({ ...form, provider: v }),
v => handleChange({ ...form, provider: v }),
)}

{form.provider === 'nordpool_official' && (
Expand Down