Skip to content

fix: reset price fields when switching to Octopus provider#70

Open
pookey wants to merge 1 commit into
johanzander:mainfrom
pookey:fix/octopus-price-defaults
Open

fix: reset price fields when switching to Octopus provider#70
pookey wants to merge 1 commit into
johanzander:mainfrom
pookey:fix/octopus-price-defaults

Conversation

@pookey

@pookey pookey commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • When switching from Nord Pool to Octopus Energy in the settings UI, the markup rate, VAT multiplier, and additional costs fields are hidden but their old values persist and are still sent to the backend. This causes the optimizer to apply incorrect price adjustments (e.g. Swedish 25% VAT and grid fees) on top of Octopus rates that are already all-in.
  • Auto-reset these fields to safe defaults (markupRate=0, vatMultiplier=1, additionalCosts=0) when the provider radio switches to Octopus.

Test plan

  • Open Settings → Electricity Pricing
  • Set provider to Nord Pool, enter non-zero markup/VAT/additional costs
  • Switch provider to Octopus Energy
  • Verify markup rate = 0, VAT multiplier = 1, additional costs = 0
  • Save and confirm backend receives the reset values
  • Switch back to Nord Pool — fields should remain at their reset values (user re-enters as needed)

🤖 Generated with Claude Code

@johanzander

Copy link
Copy Markdown
Owner

This should have been fixed in 8.2.0, different implementation. please verify and we can close this PR.

…ovider

When switching from Nord Pool to Octopus Energy, the markup rate, VAT
multiplier, and additional costs fields are hidden in the UI but their
old values are still sent to the backend. This causes the optimizer to
apply incorrect price adjustments (e.g. Swedish 25% VAT and grid fees)
on top of Octopus rates that are already all-in.

Reset these fields to safe defaults (markupRate=0, vatMultiplier=1,
additionalCosts=0) on provider switch so the backend sees correct values.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@pookey pookey force-pushed the fix/octopus-price-defaults branch from f64fbf9 to 50d2488 Compare April 17, 2026 11:58
@johanzander

Copy link
Copy Markdown
Owner

@pookey - can you verify if this has been fixed, in that case I close issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants