[swiftsrc2cpg] Call and type decl member/access rework #5692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- no more local from assignment to type decl member - assignment to type decl member is now correctly attached to the constructor block - no member from method/function under type decl - proper call base - implicit self access to member from identifier
maltek
reviewed
Nov 6, 2025
...ontends/swiftsrc2cpg/src/main/scala/io/joern/swiftsrc2cpg/astcreation/AstCreatorHelper.scala
Outdated
Show resolved
Hide resolved
...frontends/swiftsrc2cpg/src/main/scala/io/joern/swiftsrc2cpg/astcreation/AstNodeBuilder.scala
Outdated
Show resolved
Hide resolved
...n-cli/frontends/swiftsrc2cpg/src/test/scala/io/joern/swiftsrc2cpg/passes/ast/CallTests.scala
Outdated
Show resolved
Hide resolved
maltek
reviewed
Nov 6, 2025
...ontends/swiftsrc2cpg/src/main/scala/io/joern/swiftsrc2cpg/astcreation/AstCreatorHelper.scala
Outdated
Show resolved
Hide resolved
...swiftsrc2cpg/src/test/scala/io/joern/swiftsrc2cpg/passes/ast/SimpleAstCreationPassTest.scala
Show resolved
Hide resolved
max-leuthaeuser
force-pushed
the
max/callAndMemberRework
branch
from
b85667d to
21474f1
Compare
max-leuthaeuser
force-pushed
the
max/callAndMemberRework
branch
from
21474f1 to
ac30297
Compare
maltek
reviewed
Nov 7, 2025
...ontends/swiftsrc2cpg/src/main/scala/io/joern/swiftsrc2cpg/astcreation/AstCreatorHelper.scala
Outdated
Show resolved
Hide resolved
…src2cpg/astcreation/AstCreatorHelper.scala Co-authored-by: maltek <[email protected]>
fix broken attribute diffgraph add
max-leuthaeuser
force-pushed
the
max/callAndMemberRework
branch
from
abbb7ca to
d99b019
Compare
…thods - simple call to static function detection - self param for synthetic constructor methods
max-leuthaeuser
force-pushed
the
max/callAndMemberRework
branch
from
9c513f5 to
87a8f34
Compare
ml86
requested changes
Nov 14, 2025
...n-cli/frontends/swiftsrc2cpg/src/test/scala/io/joern/swiftsrc2cpg/passes/ast/CallTests.scala
Show resolved
Hide resolved
...n-cli/frontends/swiftsrc2cpg/src/test/scala/io/joern/swiftsrc2cpg/passes/ast/CallTests.scala
Outdated
Show resolved
Hide resolved
ml86
reviewed
Nov 14, 2025
Contributor
ml86
left a comment
ml86
left a comment
There was a problem hiding this comment.
I did not see a test for a call to an extension method and also calls on protocols. If the are missing please add them.
...n-cli/frontends/swiftsrc2cpg/src/test/scala/io/joern/swiftsrc2cpg/passes/ast/CallTests.scala
Show resolved
Hide resolved
ml86
requested changes
Nov 17, 2025
Contributor
ml86
left a comment
ml86
left a comment
There was a problem hiding this comment.
Please also add a test where one class implements two protocols.
...n-cli/frontends/swiftsrc2cpg/src/test/scala/io/joern/swiftsrc2cpg/passes/ast/CallTests.scala
Outdated
Show resolved
Hide resolved
ml86
approved these changes
Nov 17, 2025
Contributor
Author
|
@maltek We lose https://github.com/ShiftLeftSecurity/codescience/blob/04601283b4c56be30aec56f735e46adc2022152b/sptestV2/expectations/swiftsrc2cpg-DVIA-v2/DVIA-v2.cpg.sptest.json#L7 with this PR, the other findings are all fine. |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes:
There is no way to determine whether a call is a call to a static method/function at the moment. The SwiftParser does not provide that information. I will extend the utils handling compiler information for this purpose. This would go beyond the scope of this PR (its already large enough). Will do a follow up PR.