simple call to static function detection

Author: max-leuthaeuser

joern-cli/frontends/swiftsrc2cpg/src/main/scala/io/joern/swiftsrc2cpg/astcreation/AstForExprSyntaxCreator.scala

@@ -286,15 +286,15 @@ trait AstForExprSyntaxCreator(implicit withSchemaValidation: ValidationMode) {
     if (GlobalBuiltins.builtins.contains(calleeCode)) {
       createBuiltinStaticCall(node, callee, calleeCode)
     } else {
-      // TODO: extend the GsonTypeInfoReader to query for information whether
-      //  the call is a call to a static function and generate a proper static call here
       callee match {
         case m: MemberAccessExprSyntax if m.base.isEmpty || code(m.base.get) == "self" =>
           // referencing implicit self
           val selfTpe  = typeForSelfExpression()
           val selfNode = identifierNode(node, "self", "self", selfTpe)
           scope.addVariableReference("self", selfNode, selfTpe, EvaluationStrategies.BY_REFERENCE)
           handleCallNodeArgs(node, Ast(selfNode), code(m.declName.baseName))
+        case m: MemberAccessExprSyntax if isRefToStaticFunction(calleeCode) =>
+          createBuiltinStaticCall(node, callee, calleeCode)
         case m: MemberAccessExprSyntax =>
           val memberCode = code(m.declName)
           handleCallNodeArgs(node, astForNode(m.base.get), memberCode)
@@ -354,6 +354,11 @@ trait AstForExprSyntaxCreator(implicit withSchemaValidation: ValidationMode) {
     }
   }
 
+  private def isRefToStaticFunction(calleeCode: String): Boolean = {
+    // TODO: extend the GsonTypeInfoReader to query for information whether the call is a call to a static function
+    calleeCode.headOption.exists(_.isUpper) && !calleeCode.contains("(") && !calleeCode.contains(")")
+  }
+
   private def isRefToConstructor(func: FunctionCallExprSyntax, node: ExprSyntax): Boolean = {
     if (!config.swiftBuild) {
       // Early exit; without types from the compiler we will be unable to identify constructor calls anyway.

joern-cli/frontends/swiftsrc2cpg/src/main/scala/io/joern/swiftsrc2cpg/passes/GlobalBuiltins.scala

@@ -21,7 +21,7 @@ object GlobalBuiltins {
     "Set",        // Creates a set from a sequence
 
     // Types and type casting
-    "type",           // Returns the dynamic type of a value
+    "type",           // Returns the dynamic type of some value
     "numericCast",    // Returns the given integer as the equivalent value in a different integer type
     "unsafeDowncast", // Returns the given instance cast unconditionally to the specified type
     "unsafeBitCast",  // Returns the bits of the given instance, interpreted as having the specified type
@@ -89,7 +89,7 @@ object GlobalBuiltins {
 
     // C Interoperability
     "withVaList", // Invokes the given closure with a C va_list argument derived from the given array of arguments
-    "getVaList", // Returns a CVaListPointer that is backed by autoreleased storage, built from the given array of arguments
+    "getVaList", // Returns a CVaListPointer that is backed by auto-released storage, built from the given array of arguments
 
     // Miscellaneous Functions
     "swap",    // Exchanges the values of two variables

joern-cli/frontends/swiftsrc2cpg/src/test/scala/io/joern/swiftsrc2cpg/passes/ast/CallTests.scala

@@ -103,6 +103,22 @@ class CallTests extends SwiftCompilerSrc2CpgSuite {
       returnId.typeFullName shouldBe "SwiftTest.Foo"
     }
 
+    "be correct for simple call to static function" in {
+      // TODO: extend the GsonTypeInfoReader to query for information whether the call is a call to a static function
+      val testCode =
+        """
+          |func main() {
+          |  Foo.staticFunc()
+          |}
+          |""".stripMargin
+      val cpg = code(testCode)
+
+      val List(staticFuncCall) = cpg.call.nameExact("staticFunc").l
+      staticFuncCall.methodFullName shouldBe "Foo.staticFunc"
+      staticFuncCall.dispatchType shouldBe DispatchTypes.STATIC_DISPATCH
+      staticFuncCall.argument shouldBe empty
+    }
+
   }
 
 }