Add missing Tx.NamedQueryContext #914
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelshobbs
force-pushed
the
feature/tx-named-query-context
branch
2 times, most recently
from
55c1417 to
6133f16
Compare
michaelshobbs
force-pushed
the
feature/tx-named-query-context
branch
from
6133f16 to
e19240b
Compare
|
@dlsniper I find myself needing this exact same addition, and you seem to be the most active contributor on this project at the moment. What would it take to get some eyes on this and get it merged? |
|
Hi, @ringmaster217. This is a duplicate of at least a few other opened PRs, e.g., #724 or #565. I'll close this for now with the mention that it also lacks a test, which we have #724, for example. As for merging the others, as @ardan-bkennedy and I are ramping up the maintenance of the repository, we'll try to merge this as soon as we can. Thank you for your understanding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to use a postgres
INSERT ... RETURNINGstmt in a transaction, I found that there was a(*sqlx.Tx).NamedQuerybut not a(*sqlx.Tx).NamedQueryContext. This PR attempts to remedy that.