Skip to content

[issue-447] added NamedQueryContext method on sqlx.Tx #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[issue-447] added NamedQueryContext method on sqlx.Tx #565

wants to merge 1 commit into from

Conversation

meh-
Copy link

@meh- meh- commented Oct 7, 2019 •
edited
Loading

Issue-447
added NamedQueryContext method on *sqlx.Tx

@coveralls
Copy link

coveralls commented Oct 7, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 117

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 67.689%
Totals Coverage Status
Change from base Build 113: 0.7%
Covered Lines: 1986
Relevant Lines: 2934
💛 - Coveralls

@dackroyd
Copy link

@jmoiron any reason not to move ahead with this one? Similar PRs have been raised before without any feedback. Not having this in places means that the transaction type can't be used in places where the database can

@taywrobel taywrobel mentioned this pull request May 12, 2020
Closed
@staugaard
Copy link

Why is this one not merged?

@GerardRodes
Copy link

This one would be useful

@glebselyukov
Copy link

@jmoiron please merge this PR, without it it's impossible to use this functionality in abstractions over *DB and *Tx

@dlsniper dlsniper added the could merge The PR look safe enough to merge label Feb 1, 2024
@dlsniper dlsniper mentioned this pull request Apr 16, 2024
Closed
@sashayakovtseva
Copy link

Hi @jmoiron @dlsniper

Any chance to get this merged?

@sashayakovtseva
Copy link

or @ardan-bkennedy, as mentioned in #914 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staugaard staugaard staugaard approved these changes

@arp242 arp242 arp242 approved these changes

@omertoast omertoast omertoast approved these changes

Assignees
No one assigned
Labels
could merge The PR look safe enough to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@meh- @coveralls @dackroyd @staugaard @GerardRodes @glebselyukov @sashayakovtseva @arp242 @omertoast @dlsniper