Issues/951/upgrades breaking #962
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jknack The solution in 4.3.0 for allowing records in #826 of checking java version and then adding the method value resolver is flawed in my opinion and is going to continue to cause bugs like #951
This pull request effectively makes records work by default for folks using new JDKs while still allowing existing previous users using
defaultValueResolversto have templates that behave the same.I highly recommend we try to get this in a release soon to minimize the window that folks will not inherently rely on methods being resolved by default (ie the users who just started using handlebars picking 4.3.0 and relying on the flawed default behavior).