-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat: Improve toast messages and errors #6892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
github-roushan
wants to merge
16
commits into
janhq:dev
Choose a base branch
from
github-roushan:improve-error-message
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
958ad06
feat: Improve toast messages and errors
github-roushan 0817f57
Merge branch 'dev' into improve-error-message
github-roushan 8feb31b
Merge branch 'dev' into improve-error-message
github-roushan d300b51
Merge branch 'dev' into improve-error-message
github-roushan 90ff1c9
Merge branch 'dev' into improve-error-message
github-roushan abdf15e
Merge branch 'dev' into improve-error-message
github-roushan bd7368c
Merge branch 'dev' into improve-error-message
github-roushan 2b159d5
Merge branch 'dev' into improve-error-message
github-roushan 474e444
Merge branch 'dev' into improve-error-message
github-roushan 61e6278
Merge branch 'dev' into improve-error-message
github-roushan 515c57a
Merge branch 'dev' into improve-error-message
github-roushan 8d1c5ff
Merge branch 'dev' into improve-error-message
github-roushan 952ad15
Merge branch 'dev' into improve-error-message
github-roushan e5a80e7
Merge branch 'dev' into improve-error-message
github-roushan 00ccc50
Merge branch 'janhq:dev' into improve-error-message
github-roushan bfe6159
Merge branch 'dev' into improve-error-message
github-roushan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can define a generic func for reusability.