feat: Improve toast messages and errors #6892
Conversation
- Add preflight option to get metadata and actionable errors - Add Token Validation Timeout - Improve Various Toasts for download action - Improve validate button ux
github-roushan
force-pushed
the
improve-error-message
branch
from
dc630fa to
958ad06
Compare
|
@github-roushan can you share some screenshots for us to grasp the idea how this fixes? |
Screencast.from.2025-11-19.11-26-22.webmHere @Vanalite |
|
@Vanalite. To add more context. the status code is captured and passed around giving more context on what has happened and for this issue we add a toast with redirection to add the key in settings. |
|
@Vanalite. Do you need anything else? |
|
@github-roushan Pretty cool! But the validation button seems off with other designs. Now only HF has token validation while the others don't. I would recommend to not have the validation button there but let the general error message yields out similarly to how invalid token behaves on other remote providers |
|
@Vanalite . Will remove the button. or i can add the button to everyother place. let me know,what is your design guideline |
| title={t('hub:downloadModel')} | ||
| onClick={() => { | ||
| onClick={async () => { | ||
| const preflight = await serviceHub |
There was a problem hiding this comment.
I think you can define a generic func for reusability.
We're now embrace the simplicity. Since we only have a check ✅ icon (e.g import model), you can apply it to the validation. I'm not sure if you can mass apply the validation to all remote providers. In case it's causing trouble, remove the button would be fine |
2 participants
Describe Your Changes
Fixes Issues
Self Checklist