Fix unwanted reconcile in Server and enqueue logic in maintenance #539
+285
−196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagadeesh-nagaraja
requested review from
Nuckal777,
afritzler and
stefanhipfel
nagadeesh-nagaraja
force-pushed
the
consmeticImp
branch
2 times, most recently
from
f546819 to
bb88898
Compare
Contributor
|
Thanks, could you please remove the changes of #540 from this PR? |
Contributor
Author
I will rebase once that PR merges. this PR will fail unit tests without the test fixes in the other PR :D |
nagadeesh-nagaraja
force-pushed
the
consmeticImp
branch
from
bb88898 to
7653c40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Server Reconciler avoid double reconciliation logic. This helps avoid overloading BMC, multiple reconcile during sequencial update
ServerMaintenance Reconcile logic for server updates was wrong, fix that. ( this was caught with changes done above)