Testing

Author: nagadeesh-nagaraja

internal/controller/bmcversion_controller.go

@@ -64,7 +64,7 @@ func (r *BMCVersionReconciler) Reconcile(ctx context.Context, req ctrl.Request)
 	if err := r.Get(ctx, req.NamespacedName, bmcVersion); err != nil {
 		return ctrl.Result{}, client.IgnoreNotFound(err)
 	}
-	log.V(1).Info("Reconciling BMCVersion")
+	log.V(1).Info("Reconciling BMCVersion", "TESTING servermaintenance refs", bmcVersion.Spec.ServerMaintenanceRefs)
 
 	return r.reconcileExists(ctx, log, bmcVersion)
 }
@@ -110,7 +110,9 @@ func (r *BMCVersionReconciler) delete(ctx context.Context, log logr.Logger, bmcV
 }
 
 func (r *BMCVersionReconciler) cleanupServerMaintenanceReferences(ctx context.Context, log logr.Logger, bmcVersion *metalv1alpha1.BMCVersion) error {
+	log.V(1).Info("to clean up ServerMaintenance ref")
 	if bmcVersion.Spec.ServerMaintenanceRefs == nil {
+		log.V(1).Info("Testing: ServerMaintenance ref is nil, nothing to clean up")
 		return nil
 	}
 	// try to get the serverMaintenances created
@@ -129,6 +131,7 @@ func (r *BMCVersionReconciler) cleanupServerMaintenanceReferences(ctx context.Co
 		}
 	}
 
+	providedServerMaintenance := map[string]*metalv1alpha1.ServerMaintenance{}
 	if len(missingServerMaintenanceRef) != len(bmcVersion.Spec.ServerMaintenanceRefs) {
 		// delete the serverMaintenance if not marked for deletion already
 		for _, serverMaintenance := range serverMaintenances {
@@ -139,6 +142,7 @@ func (r *BMCVersionReconciler) cleanupServerMaintenanceReferences(ctx context.Co
 					finalErr = append(finalErr, err)
 				}
 			} else {
+				providedServerMaintenance[serverMaintenance.Name] = serverMaintenance
 				log.V(1).Info(
 					"ServerMaintenance not deleted",
 					"ServerMaintenance", serverMaintenance.Name,
@@ -150,8 +154,19 @@ func (r *BMCVersionReconciler) cleanupServerMaintenanceReferences(ctx context.Co
 	}
 
 	if len(finalErr) == 0 {
+		var updatedRef []metalv1alpha1.ServerMaintenanceRefItem
+		if len(providedServerMaintenance) == 0 {
+			updatedRef = nil
+		} else {
+			updatedRef = make([]metalv1alpha1.ServerMaintenanceRefItem, 0, len(providedServerMaintenance))
+			for _, refs := range bmcVersion.Spec.ServerMaintenanceRefs {
+				if _, ok := providedServerMaintenance[refs.ServerMaintenanceRef.Name]; ok {
+					updatedRef = append(updatedRef, refs)
+				}
+			}
+		}
 		// all serverMaintenance are deleted
-		err := r.patchMaintenanceRequestRefOnBMCVersion(ctx, log, bmcVersion, nil)
+		err := r.patchMaintenanceRequestRefOnBMCVersion(ctx, log, bmcVersion, updatedRef)
 		if err != nil {
 			return fmt.Errorf("failed to clean up serverMaintenance ref in bmcVersion status: %w", err)
 		}