Skip to content

Conversation

@xkonni
Copy link
Contributor

@xkonni xkonni commented Oct 9, 2025

Proposed Changes

This PR allows the metal-api to hold more information about the server. It is based on #452 and the first commit is actually from that PR, as it was not yet merged.

  • update crd
    • add all networkInterfaces, include ipv4 + ipv6 ips and status
    • add lldp information
  • update registry
  • update controller to feed the newly available data in the registry into the crd

@xkonni xkonni force-pushed the enh/inventory2 branch 2 times, most recently from 5dd20f9 to a61fd4d Compare October 13, 2025 05:55
@xkonni
Copy link
Contributor Author

xkonni commented Oct 15, 2025

From our discussion:

This PR should take information from the registry, provided by #452 and update the networkInterfaces struct in the servers crd.

Example:

... 
networkInterfaces:
  - name: enp123  
    carrierState: up/down
    macAddress: aa:bb:cc:dd:ee:ff
    ipAddresses: [] # v4 and v6
    neighbors:
      - macAddress: 44:ae:25:78:db:41
        portDescription: topology/pod-1/protpaths-2115-2116/pathep-[openstack-baremetal-node008-bb097]
        portID: Eth1/17
        systemDescription: topology/pod-1/node-2116
        systemName: qa-de-1-aci-2116-bb097
  - name: enp456
...

Copy link
Contributor

@nagadeesh-nagaraja nagadeesh-nagaraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#452 is still part of this PR, I though the plan was to merge it separately?

@afritzler
Copy link
Member

@xkonni can you please rebase this PR?

@afritzler afritzler changed the title update servers crd, add lldp and update networkInterface Extend NetworkInterface status with LLDP neighbor information Oct 27, 2025
@github-actions github-actions bot added size/L documentation Improvements or additions to documentation and removed size/XL labels Oct 27, 2025
@xkonni
Copy link
Contributor Author

xkonni commented Nov 27, 2025

rebased, updated with our discussed changes and more robust lldpctl output parsing.

@Nuckal777 Nuckal777 merged commit 705e542 into main Nov 27, 2025
14 checks passed
@Nuckal777 Nuckal777 deleted the enh/inventory2 branch November 27, 2025 17:47
@github-project-automation github-project-automation bot moved this to Done in Roadmap Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-change area/metal-automation documentation Improvements or additions to documentation enhancement New feature or request size/L

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

8 participants