address review comments

Author: xkonni

api/v1alpha1/server_types.go

@@ -290,6 +290,13 @@ type NetworkInterface struct {
 	// +required
 	Name string `json:"name"`
 
+	// IP is the IP address assigned to the network interface.
+	// Deprecated: Use IPs instead. Kept for backward compatibility, always nil.
+	// +kubebuilder:validation:Type=string
+	// +kubebuilder:validation:Schemaless
+	// +optional
+	IP *IP `json:"ip,omitempty"`
+
 	// IPs is a list of IP addresses (both IPv4 and IPv6) assigned to the network interface.
 	// +optional
 	IPs []IP `json:"ips,omitempty"`

api/v1alpha1/zz_generated.deepcopy.go

@@ -465,6 +465,11 @@ spec:
                       description: CarrierStatus is the operational carrier status
                         of the network interface.
                       type: string
+                    ip:
+                      description: |-
+                        IP is the IP address assigned to the network interface.
+                        Deprecated: Use IPs instead. Kept for backward compatibility, always nil.
+                      type: string
                     ips:
                       description: IPs is a list of IP addresses (both IPv4 and IPv6)
                         assigned to the network interface.

config/crd/bases/metal.ironcore.dev_servers.yaml

@@ -836,11 +836,7 @@ func (r *ServerReconciler) extractServerDetailsFromRegistry(ctx context.Context,
 			}
 		}
 
-		// Set the IPs field with all collected IP addresses
-		if len(allIPs) > 0 {
-			nic.IPs = allIPs
-		}
-
+		nic.IPs = allIPs
 		nics = append(nics, nic)
 	}
 

internal/controller/server_controller.go

@@ -40,8 +40,8 @@ func collectNetworkData() ([]registry.NetworkInterface, error) {
 		}
 
 		addrs, err := iface.Addrs()
-		if err != nil {
-			// If we can't get addresses, still include the interface with empty IP
+		// If we can't get addresses or interface has no addresses, still include it with empty IP
+		if err != nil || len(addrs) == 0 {
 			networkInterface := registry.NetworkInterface{
 				Name:          iface.Name,
 				IPAddresses:   []string{},
@@ -50,21 +50,7 @@ func collectNetworkData() ([]registry.NetworkInterface, error) {
 			}
 			networkInterfaces = append(networkInterfaces, networkInterface)
 			continue
-		}
-
-		// If interface has no addresses, still include it
-		if len(addrs) == 0 {
-			networkInterface := registry.NetworkInterface{
-				Name:          iface.Name,
-				IPAddresses:   []string{},
-				MACAddress:    iface.HardwareAddr.String(),
-				CarrierStatus: status,
-			}
-			networkInterfaces = append(networkInterfaces, networkInterface)
-			continue
-		}
-
-		// Collect all IP addresses (both IPv4 and IPv6) in a single slice
+		} // Collect all IP addresses (both IPv4 and IPv6) in a single slice
 		var ipAddresses []string
 
 		for _, addr := range addrs {