Fix exit codes in BCC python tools for reliable error handling #5399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several tools were using plain exit() when no kprobes or tracepoints could be attached. This returned 0 to the shell, incorrectly signaling success. Update these cases to use exit(1) so the failure is properly reported to the caller. Signed-off-by: Hoyeon Lee <[email protected]>
When symbols such as *_file_operations or vm_zone_stat are not found in /proc/kallsyms, the scripts exited with code 0. Change these cases to exit(1) so that missing symbol errors are reported correctly, rather than appearing as successful termination. Signed-off-by: Hoyeon Lee <[email protected]>
Many tools were exiting with code 0 when given invalid or conflicting options (e.g. mutually exclusive arguments, zero intervals). This patch updates those cases to exit(1), ensuring argument errors propagate as failures to the caller. Signed-off-by: Hoyeon Lee <[email protected]>
HoyeonRhee
requested review from
brendangregg,
chenhengqi,
ekyooo and
yonghong-song
as code owners
ekyooo
reviewed
Sep 19, 2025
ekyooo
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some BCC tools currently exit with status code 0 even when encountering
fatal errors. This makes it impossible to distinguish between success and
failure, which makes smoke tests (and packaging checks) unreliable.
Examples are:
This PR updates the BCC python tools to consistently return exit(1) in
these cases. This ensures errors are clearly reported and allows the
tools to be used more effectively in automated workflows such as smoke
testing.