tools: return error code on invalid options

Many tools were exiting with code 0 when given invalid or conflicting
options (e.g. mutually exclusive arguments, zero intervals). This patch
updates those cases to exit(1), ensuring argument errors propagate as
failures to the caller.

Signed-off-by: Hoyeon Lee <[email protected]>

Author: HoyeonRhee

tools/biolatency.py

@@ -65,7 +65,7 @@
 
 if args.flags and args.disks:
     print("ERROR: can only use -D or -F. Exiting.")
-    exit()
+    exit(1)
 
 # define BPF program
 bpf_text = """

tools/btrfsdist.py

@@ -53,7 +53,7 @@
     label = "usecs"
 if args.interval and int(args.interval) == 0:
     print("ERROR: interval 0. Exiting.")
-    exit()
+    exit(1)
 debug = 0
 
 # define BPF program

tools/cpuunclaimed.py

@@ -164,7 +164,7 @@ def check_runnable_weight_field():
     interval = 0.2
 if args.interval != -1 and (args.fullcsv or args.csv):
     print("ERROR: cannot use interval with either -j or -J. Exiting.")
-    exit()
+    exit(1)
 if args.interval == -1:
     args.interval = "1"
 interval = float(args.interval)

tools/criticalstat.py

@@ -54,7 +54,7 @@
 
 if debugfs_path == "":
     print("ERROR: Unable to find debugfs mount point");
-    sys.exit(0);
+    sys.exit(1);
 
 trace_path = debugfs_path + b"/tracing/events/preemptirq/";
 

tools/ext4dist.py

@@ -53,7 +53,7 @@
     label = "usecs"
 if args.interval and int(args.interval) == 0:
     print("ERROR: interval 0. Exiting.")
-    exit()
+    exit(1)
 debug = 0
 
 # define BPF program

tools/nfsdist.py

@@ -47,7 +47,7 @@
     label = "usecs"
     if args.interval and int(args.interval) == 0:
         print("ERROR: interval 0. Exiting.")
-        exit()
+        exit(1)
 debug = 0
 
 # define BPF program

tools/offcputime.py

@@ -122,7 +122,7 @@ def stack_id_err(stack_id):
 
 if args.folded and args.offset:
     print("ERROR: can only use -f or -s. Exiting.")
-    exit()
+    exit(1)
 
 # signal handler
 def signal_ignore(signal, frame):

tools/old/offcputime.py

@@ -51,7 +51,7 @@
 maxdepth = 20    # and MAXDEPTH
 if args.pid and args.useronly:
     print("ERROR: use either -p or -u.")
-    exit()
+    exit(1)
 
 # signal handler
 def signal_ignore(signal, frame):

tools/old/offwaketime.py

@@ -55,7 +55,7 @@
 maxtdepth = 20    # and MAXTDEPTH
 if args.pid and args.useronly:
     print("ERROR: use either -p or -u.")
-    exit()
+    exit(1)
 
 # signal handler
 def signal_ignore(signal, frame):

tools/old/wakeuptime.py

@@ -51,7 +51,7 @@
 maxdepth = 20    # and MAXDEPTH
 if args.pid and args.useronly:
     print("ERROR: use either -p or -u.")
-    exit()
+    exit(1)
 
 # signal handler
 def signal_ignore(signal, frame):