-
Notifications
You must be signed in to change notification settings - Fork 4
Add simulation flags to groups and tests #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
709d388
ae208e2
e57e922
5a846d7
691c80a
e9b6df7
7df1420
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,7 +12,7 @@ module DaVinciPASTestKit | |
| <%- if verifies_requirements -%> | ||
| verifies_requirements <%= verifies_requirements.map { |r| "'#{r}'" }.join(', ') %> | ||
| <%- end -%> | ||
| <% if run_as_group %>run_as_group<% end %> | ||
| <% if run_as_group? %>run_as_group<% end %> | ||
| <% if system == 'client'%> | ||
| <% test_id_list.each do |id| %> | ||
| test from: :<%= id %><% end %> | ||
|
|
@@ -112,9 +112,24 @@ module DaVinciPASTestKit | |
| - [PAS PractitionerRole](https://hl7.org/fhir/us/davinci-pas/STU2/StructureDefinition-profile-practitionerrole.html) | ||
| )<% end %> | ||
| run_as_group | ||
| <% subgroup.each do |category, id_list| %> | ||
| group do | ||
| title '<%= category%>' | ||
| <%- subgroup.each do |category, id_list| -%> | ||
| <%- | ||
| title_lines = category.to_s.split("\n").map(&:strip) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure why this got so much more complicated, but it doesn't look like it is using the erb templating paradigm. Can you explain the intention of this update so we can plan how to implement it in a cleaner way? |
||
| s = " group do\n" | ||
| s << " title '#{title_lines.shift.gsub("'","\\\\'")}'\n" | ||
| title_lines.each do |extra| | ||
| if extra.start_with?("verifies_requirements") | ||
| s << " #{extra}\n" | ||
| elsif extra == 'simulation_verification' | ||
| s << " simulation_verification\n" | ||
| else | ||
| s << " #{extra}\n" | ||
| end | ||
| end | ||
| s.rstrip! | ||
| s << "\n" | ||
| -%> | ||
| <%= "\n" + s -%> | ||
| <% id_list.each do |id|%> | ||
| test from: :<%= id%><% if must_support_rename_input?(id) %> do | ||
| id :<%= alt_test_id(id, use_case) %> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is the source of the complication in the
group.rb.erbfile. Generators harbor a lot of nutty code in the name of complex code re-use. I guess we leave it.