Conversation
ljtucker
changed the title
There was a problem hiding this comment.
updating rubocop is dangerous partly because of these new refactors, which seem to often be more trouble than they are worth. Probably a good idea to decide our policy on this kind of thing so that we have a go to approach. I'm fine with most of the changes as is, but there are some low-hanging fruit that I think better to actually address rather than disable.
I'm also inclined to have this merged into the support-v2.2.0 branch first instead of straight to main since that is where most of our activity is going.
Also - gemspec needs to be updated to have inferno_core 1.1.2 as the minimum required version:
spec.add_runtime_dependency 'inferno_core', '~> 1.1', '>= 1.1.2'
| # rubocop:disable Naming/PredicateMethod | ||
| def simulation_verification | ||
| user_input? | ||
| end | ||
| # rubocop:enable Naming/PredicateMethod | ||
|
|
There was a problem hiding this comment.
Simple refactor to follow the style rather than disabling it, could be done for skip_if_empty in several places as well.
| # rubocop:disable Naming/PredicateMethod | |
| def simulation_verification | |
| user_input? | |
| end | |
| # rubocop:enable Naming/PredicateMethod | |
| def simulation_verification? | |
| user_input? | |
| end |
| title '<%= category%>' | ||
| <%- subgroup.each do |category, id_list| -%> | ||
| <%- | ||
| title_lines = category.to_s.split("\n").map(&:strip) |
There was a problem hiding this comment.
I'm not sure why this got so much more complicated, but it doesn't look like it is using the erb templating paradigm. Can you explain the intention of this update so we can plan how to implement it in a cleaner way?
| { | ||
| '$submit Element Support' => { | ||
| 'Submission of claims to the $submit operation for must support validation' => submit_tests, | ||
| "[USER INPUT VALIDATION] Submit Request Must Support'" \ |
There was a problem hiding this comment.
Looks like this is the source of the complication in the group.rb.erb file. Generators harbor a lot of nutty code in the name of complex code re-use. I guess we leave it.
|
moved into the 2.2 branch instead |
3 participants
Summary
Testing Guidance