-
Notifications
You must be signed in to change notification settings - Fork 5
Enhancing load profile source. #1295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -69,7 +69,7 @@ class SqlLoadProfileSourceIT extends Specification implements TestContainerHelpe | |
|
||
then: | ||
value.present | ||
value.get().p.get() == G3_VALUE_00MIN.p.get() | ||
value.get().provide().p.get() == G3_VALUE_00MIN.p.get() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To be honest the usage looks a bit odd, get() and provide() are semantically similar and therfor one could assume to do the same. On the other hand get can be interpreted as the value is available while provide could be interpreted as the value will now be fetched or generated. So maybe this results in some general question: is this the best way to do so? |
||
} | ||
|
||
def "A SqlTimeSeriesSource can read all value data"() { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here last would be a new sampled value while one would expect the sampled value from last time step, isn't this a problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe it's not last but actual?