Enhancing load profile source. #1295
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielfeismann
requested changes
Jul 23, 2025
| @Override | ||
| public LoadValues.Provider buildProvider( | ||
| RandomLoadValues loadValue, ZonedDateTime time, RandomLoadProfile loadProfile) { | ||
| return last -> loadValue.sample(time); |
There was a problem hiding this comment.
Here last would be a new sampled value while one would expect the sampled value from last time step, isn't this a problem?
There was a problem hiding this comment.
maybe it's not last but actual?
| @@ -69,7 +69,7 @@ class SqlLoadProfileSourceIT extends Specification implements TestContainerHelpe | |||
|
|
|||
| then: | |||
| value.present | |||
| value.get().p.get() == G3_VALUE_00MIN.p.get() | |||
| value.get().provide().p.get() == G3_VALUE_00MIN.p.get() | |||
There was a problem hiding this comment.
To be honest the usage looks a bit odd, get() and provide() are semantically similar and therfor one could assume to do the same. On the other hand get can be interpreted as the value is available while provide could be interpreted as the value will now be fetched or generated.
So maybe this results in some general question: is this the best way to do so?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1294