Add Provisioning YAML File #180
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| # Generated file; do not modify. | ||
|
|
||
| sdbusplus_current_path = 'xyz/openbmc_project/Provisioning/Provisioning' | ||
|
|
||
| generated_sources += custom_target( | ||
| 'xyz/openbmc_project/Provisioning/Provisioning__cpp'.underscorify(), | ||
| input: [ | ||
| '../../../../../yaml/xyz/openbmc_project/Provisioning/Provisioning.interface.yaml', | ||
| ], | ||
| output: [ | ||
| 'common.hpp', | ||
| 'server.hpp', | ||
| 'server.cpp', | ||
| 'aserver.hpp', | ||
| 'client.hpp', | ||
| ], | ||
| depend_files: sdbusplusplus_depfiles, | ||
| command: [ | ||
| sdbuspp_gen_meson_prog, | ||
| '--command', | ||
| 'cpp', | ||
| '--output', | ||
| meson.current_build_dir(), | ||
| '--tool', | ||
| sdbusplusplus_prog, | ||
| '--directory', | ||
| meson.current_source_dir() / '../../../../../yaml', | ||
| 'xyz/openbmc_project/Provisioning/Provisioning', | ||
| ], | ||
| install: should_generate_cpp, | ||
| install_dir: [ | ||
| get_option('includedir') / sdbusplus_current_path, | ||
| get_option('includedir') / sdbusplus_current_path, | ||
| false, | ||
| get_option('includedir') / sdbusplus_current_path, | ||
| get_option('includedir') / sdbusplus_current_path, | ||
| ], | ||
| build_by_default: should_generate_cpp, | ||
| ) | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # Generated file; do not modify. | ||
| subdir('Provisioning') | ||
|
|
||
| sdbusplus_current_path = 'xyz/openbmc_project/Provisioning' | ||
|
|
||
| generated_markdown += custom_target( | ||
| 'xyz/openbmc_project/Provisioning/Provisioning__markdown'.underscorify(), | ||
| input: [ | ||
| '../../../../yaml/xyz/openbmc_project/Provisioning/Provisioning.interface.yaml', | ||
| ], | ||
| output: ['Provisioning.md'], | ||
| depend_files: sdbusplusplus_depfiles, | ||
| command: [ | ||
| sdbuspp_gen_meson_prog, | ||
| '--command', | ||
| 'markdown', | ||
| '--output', | ||
| meson.current_build_dir(), | ||
| '--tool', | ||
| sdbusplusplus_prog, | ||
| '--directory', | ||
| meson.current_source_dir() / '../../../../yaml', | ||
| 'xyz/openbmc_project/Provisioning/Provisioning', | ||
| ], | ||
| install: should_generate_markdown, | ||
| install_dir: [inst_markdown_dir / sdbusplus_current_path], | ||
| build_by_default: should_generate_markdown, | ||
| ) | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| name: xyz.openbmc_project.Provisioning | ||
| description: > | ||
| Interface to represent the provisioning status of the BMC. Provides a | ||
| property to indicate whether the BMC is provisioned, and methods to initiate | ||
| provisioning and check the peer BMC connection. | ||
| properties: | ||
| - name: ProvisioningState | ||
|
There was a problem hiding this comment. 'State' sounds like it should be an enum. If it's just a bool, how just about something like 'Provisioned'? |
||
| type: boolean | ||
| flags: | ||
| - readonly | ||
| default: false | ||
| description: > | ||
| True means the BMC is in a provisioned state. | ||
|
|
||
| methods: | ||
| - name: StartProvisioning | ||
| description: > | ||
| Starts the provisioning process and updates the ProvisioningState | ||
| accordingly. | ||
| parameters: [] | ||
|
There was a problem hiding this comment. you can just leave off this field if there are no parameters |
||
|
|
||
| - name: CheckPeerBMCConnection | ||
|
There was a problem hiding this comment. @raviteja-b Is this the interface you were thinking RBMC manager would call? I don't think so, because the API I was thinking of checks if authentication is also good between the BMCs which means provisioning already has to have been completed on each. |
||
| description: > | ||
| Performs a check to determine if the peer BMC is reachable and | ||
| available for provisioning. | ||
| parameters: [] | ||
| returns: | ||
| - type: boolean | ||
| description: > | ||
| True if the peer BMC is reachable; false otherwise. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think 'name' is a recognized field at this level?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I wonder if this should be under Network. The upstream maintainer would have final say anyway I guess.